Fully disable quicer/h3 unless COWBOY_QUICER is set

This should avoid Dialyzer errors.

A CI job testing without COWBOY_QUICER has also been added.

Author: essen

.github/workflows/ci.yaml

@@ -21,6 +21,22 @@ jobs:
     if: ${{ !cancelled() }}
     uses: ninenines/ci.erlang.mk/.github/workflows/ci.yaml@master
 
+  dialyzer-no-quicer:
+    name: Dialyzer (without COWBOY_QUICER)
+    runs-on: ubuntu-latest
+    steps:
+
+    - name: Checkout repository
+      uses: actions/checkout@v4
+
+    - name: Install latest Erlang/OTP
+      uses: erlef/setup-beam@v1
+      with:
+        otp-version: '> 0'
+
+    - name: Run Dialyzer (without COWBOY_QUICER)
+      run: make dialyze COWBOY_QUICER=0
+
   examples:
     name: Check examples
     runs-on: ubuntu-latest

src/cowboy.erl

@@ -16,19 +16,19 @@
 
 -export([start_clear/3]).
 -export([start_tls/3]).
--export([start_quic/3]).
 -export([stop_listener/1]).
 -export([get_env/2]).
 -export([get_env/3]).
 -export([set_env/3]).
 
+-ifdef(COWBOY_QUICER).
+-export([start_quic/3]).
+-endif.
+
 %% Internal.
 -export([log/2]).
 -export([log/4]).
 
-%% Don't warn about the bad quicer specs.
--dialyzer([{nowarn_function, start_quic/3}]).
-
 -type opts() :: cowboy_http:opts() | cowboy_http2:opts().
 -export_type([opts/0]).
 
@@ -73,6 +73,8 @@ start_tls(Ref, TransOpts0, ProtoOpts0) ->
 	},
 	ranch:start_listener(Ref, ranch_ssl, TransOpts, cowboy_tls, ProtoOpts).
 
+-ifdef(COWBOY_QUICER).
+
 %% @todo Experimental function to start a barebone QUIC listener.
 %%       This will need to be reworked to be closer to Ranch
 %%       listeners and provide equivalent features.
@@ -151,6 +153,8 @@ port_0() ->
 	end,
 	Port.
 
+-endif.
+
 ensure_alpn(TransOpts) ->
 	SocketOpts = maps:get(socket_opts, TransOpts, []),
 	TransOpts#{socket_opts => [

src/cowboy_http3.erl

@@ -19,6 +19,8 @@
 
 -module(cowboy_http3).
 
+-ifdef(COWBOY_QUICER).
+
 -export([init/4]).
 
 %% Temporary callback to do sendfile over QUIC.
@@ -1303,3 +1305,5 @@ stream_linger(State=#state{lingering_streams=Lingering0}, StreamID) ->
 
 is_lingering_stream(#state{lingering_streams=Lingering}, StreamID) ->
 	lists:member(StreamID, Lingering).
+
+-endif.

src/cowboy_quicer.erl

@@ -16,6 +16,8 @@
 
 -module(cowboy_quicer).
 
+-ifdef(COWBOY_QUICER).
+
 %% Connection.
 -export([peername/1]).
 -export([sockname/1]).
@@ -35,55 +37,6 @@
 %% Messages.
 -export([handle/1]).
 
--ifndef(COWBOY_QUICER).
-
--spec peername(_) -> no_return().
-peername(_) -> no_quicer().
-
--spec sockname(_) -> no_return().
-sockname(_) -> no_quicer().
-
--spec peercert(_) -> no_return().
-peercert(_) -> no_quicer().
-
--spec shutdown(_, _) -> no_return().
-shutdown(_, _) -> no_quicer().
-
--spec start_bidi_stream(_, _) -> no_return().
-start_bidi_stream(_, _) -> no_quicer().
-
--spec start_unidi_stream(_, _) -> no_return().
-start_unidi_stream(_, _) -> no_quicer().
-
--spec setopt(_, _, _, _) -> no_return().
-setopt(_, _, _, _) -> no_quicer().
-
--spec send(_, _, _) -> no_return().
-send(_, _, _) -> no_quicer().
-
--spec send(_, _, _, _) -> no_return().
-send(_, _, _, _) -> no_quicer().
-
--spec send_datagram(_, _) -> no_return().
-send_datagram(_, _) -> no_quicer().
-
--spec shutdown_stream(_, _) -> no_return().
-shutdown_stream(_, _) -> no_quicer().
-
--spec shutdown_stream(_, _, _, _) -> no_return().
-shutdown_stream(_, _, _, _) -> no_quicer().
-
--spec handle(_) -> no_return().
-handle(_) -> no_quicer().
-
-no_quicer() ->
-	error({no_quicer,
-		"Cowboy must be compiled with environment variable COWBOY_QUICER=1 "
-		"or with compilation flag -D COWBOY_QUICER=1 in order to enable "
-		"QUIC support using the emqx/quic NIF"}).
-
--else.
-
 %% @todo Make quicer export these types.
 -type quicer_connection_handle() :: reference().
 -export_type([quicer_connection_handle/0]).