Bug: Dep autopatching runs even if sub-dep is already downloaded

[artman41]

assume you have the following Projects

Main Project

PROJECT = main
DEPS = other_lib sub

autopatch-other_lib::
	@echo "Autopatching on $(PROJECT)"

Sub Project

PROJECT = sub
DEPS = other_lib

autopatch-other_lib::
	@echo "Autopatching on $(PROJECT)"

In the scenario where you are developing main and run deps, the following will happen:

• other_lib is downloaded
• main's autopatch target will run for other_lib
• sub is downloaded
• sub's autopatch target will run for other_lib

I feel like this shouldn't really happen; autopatch targets (in my mind) should only run if they are in the main project, not if IS_DEP=1 is defined.

[essen]

I think that's already what it does? If deps/other_lib exists, then both downloading and autopatch don't run. If autopatch was running then it would also try to download it again (and fail) since those steps are sequential.

[artman41]

strange, I'm seeing behaviour where both autopatches run

I'll try and put together an example later and link it in the thread

[essen]

Thanks!