Implement seperate entry point script for docker compose to prevent race conditions between migration application and server db usage

Author: nir1r7

backend/Dockerfile

@@ -8,14 +8,14 @@ COPY requirements.txt .
 RUN pip install --upgrade pip && pip install --no-cache-dir -r requirements.txt
 
 # copy app source code
-COPY app ./app
-COPY alembic.ini ./alembic.ini
-COPY alembic ./alembic
+COPY . .
+
+RUN chmod +x entrypoint.sh
 
 # environment variables
 ENV PYTHONUNBUFFERED=1
 
 # entrypoint: run migrations then start up
-CMD ["sh", "-c", "alembic upgrade head && uvicorn app.main:app --host 0.0.0.0 --port 8000"]
+ENTRYPOINT ["./entrypoint.sh"]
 
 

backend/entrypoint.sh

@@ -0,0 +1,12 @@
+#!/bin/sh
+set -e
+
+echo "Waiting for database and running migrations..."
+
+until alembic upgrade head; do
+  echo "Migration failed, retrying in 2 seconds..."
+  sleep 2
+done
+
+echo "Migrations complete. Starting server..."
+exec uvicorn app.main:app --host 0.0.0.0 --port 8000

docker-compose.yml

@@ -28,19 +28,6 @@ services:
       interval: 5s
       timeout: 5s
       retries: 5
-
-  migrate:
-    image: eventrelay-api:latest
-    command: alembic upgrade head
-    environment:
-      POSTGRES_USER: eventrelayuser
-      POSTGRES_PASSWORD: 123
-      POSTGRES_DB: eventrelay
-      POSTGRES_HOST: db
-      POSTGRES_PORT: 5432
-    depends_on:
-      db:
-        condition: service_healthy
 
 volumes:
   postgres_data: