fix: stops process on service/website build errors (#861)

Author: davemooreuws

cmd/debug.go

@@ -147,7 +147,7 @@ var specCmd = &cobra.Command{
 				buildModel, err := prog.Run()
 				tui.CheckErr(err)
 				if buildModel.(build.Model).Err != nil {
-					tui.CheckErr(fmt.Errorf("error building services"))
+					tui.CheckErr(fmt.Errorf("error building migration images"))
 				}
 			}
 		}

cmd/run.go

@@ -138,15 +138,24 @@ var runCmd = &cobra.Command{
 
 			// non-interactive environment
 			for update := range allBuildUpdates {
+				if update.Status == project.ServiceBuildStatus_Error {
+					localCloud.Stop()
+					tui.CheckErr(fmt.Errorf("error building services"))
+				}
+
 				for _, line := range strings.Split(strings.TrimSuffix(update.Message, "\n"), "\n") {
 					fmt.Printf("%s [%s]: %s\n", update.ServiceName, update.Status, line)
 				}
 			}
 		} else {
 			prog := teax.NewProgram(build.NewModel(allBuildUpdates, "Building Services"))
 			// blocks but quits once the above updates channel is closed by the build process
-			_, err = prog.Run()
+			buildModel, err := prog.Run()
 			tui.CheckErr(err)
+			if buildModel.(build.Model).Err != nil {
+				localCloud.Stop()
+				tui.CheckErr(fmt.Errorf("error building services"))
+			}
 		}
 
 		websiteBuildUpdates, err := proj.BuildWebsites(loadEnv)
@@ -156,15 +165,25 @@ var runCmd = &cobra.Command{
 			if isNonInteractive() {
 				fmt.Println("building project websites")
 				for update := range websiteBuildUpdates {
+					if update.Status == project.ServiceBuildStatus_Error {
+						localCloud.Stop()
+						tui.CheckErr(fmt.Errorf("error building websites"))
+					}
+
 					for _, line := range strings.Split(strings.TrimSuffix(update.Message, "\n"), "\n") {
 						fmt.Printf("%s [%s]: %s\n", update.ServiceName, update.Status, line)
 					}
 				}
 			} else {
 				prog := teax.NewProgram(build.NewModel(websiteBuildUpdates, "Building Websites"))
 				// blocks but quits once the above updates channel is closed by the build process
-				_, err = prog.Run()
+				buildModel, err := prog.Run()
 				tui.CheckErr(err)
+
+				if buildModel.(build.Model).Err != nil {
+					localCloud.Stop()
+					tui.CheckErr(fmt.Errorf("error building websites"))
+				}
 			}
 		}
 

cmd/stack.go

@@ -198,6 +198,10 @@ var stackUpdateCmd = &cobra.Command{
 
 			// non-interactive environment
 			for update := range allBuildUpdates {
+				if update.Status == project.ServiceBuildStatus_Error {
+					tui.CheckErr(fmt.Errorf("error building services"))
+				}
+
 				for _, line := range strings.Split(strings.TrimSuffix(update.Message, "\n"), "\n") {
 					fmt.Printf("%s [%s]: %s\n", update.ServiceName, update.Status, line)
 				}
@@ -272,7 +276,7 @@ var stackUpdateCmd = &cobra.Command{
 				buildModel, err := prog.Run()
 				tui.CheckErr(err)
 				if buildModel.(build.Model).Err != nil {
-					tui.CheckErr(fmt.Errorf("error building services"))
+					tui.CheckErr(fmt.Errorf("error building migration images"))
 				}
 			}
 		}
@@ -284,15 +288,23 @@ var stackUpdateCmd = &cobra.Command{
 			if isNonInteractive() {
 				fmt.Println("building project websites")
 				for update := range websiteBuildUpdates {
+					if update.Status == project.ServiceBuildStatus_Error {
+						tui.CheckErr(fmt.Errorf("error building websites"))
+					}
+
 					for _, line := range strings.Split(strings.TrimSuffix(update.Message, "\n"), "\n") {
 						fmt.Printf("%s [%s]: %s\n", update.ServiceName, update.Status, line)
 					}
 				}
 			} else {
 				prog := teax.NewProgram(build.NewModel(websiteBuildUpdates, "Building Websites"))
 				// blocks but quits once the above updates channel is closed by the build process
-				_, err = prog.Run()
+				buildModel, err := prog.Run()
 				tui.CheckErr(err)
+
+				if buildModel.(build.Model).Err != nil {
+					tui.CheckErr(fmt.Errorf("error building websites"))
+				}
 			}
 		}