refactor!: remove app config support (#3197)

Author: pi0

docs/1.guide/1.utils.md

@@ -51,7 +51,6 @@ Nitro also exposes several built-in utils:
 - `defineRenderHandler(handler)`{lang=ts}
 - `defineRouteMeta(options)`{lang=ts} (experimental)
 - `useRuntimeConfig(event?)`{lang=ts}
-- `useAppConfig(event?)`{lang=ts}
 - `useStorage(base?)`{lang=ts}
 - `useNitroApp()`{lang=ts}
 - `defineNitroPlugin(plugin)`{lang=ts}

src/core/build/types.ts

@@ -126,24 +126,7 @@ export async function writeTypes(nitro: Nitro) {
 
   const config = [
     "// Generated by nitro",
-    `
-// App Config
-import type { Defu } from 'defu'
-
-${nitro.options.appConfigFiles
-  .map((file, index) =>
-    genTypeImport(relative(typesDir, file).replace(/\.\w+$/, ""), [
-      { name: "default", as: `appConfig${index}` },
-    ])
-  )
-  .join("\n")}
-
-type UserAppConfig = Defu<{}, [${nitro.options.appConfigFiles
-      .map((_, index: number) => `typeof appConfig${index}`)
-      .join(", ")}]>
-
-declare module "nitro/types" {
-  interface AppConfig extends UserAppConfig {}`,
+    /* ts */ `declare module "nitro/types" {`,
     nitro.options.typescript.generateRuntimeConfigTypes
       ? generateTypes(
           await resolveSchema(

src/core/config/defaults.ts

@@ -9,8 +9,6 @@ export const NitroDefaults: NitroConfig = {
   timing: isDebug,
   logLevel: isTest ? 1 : 3,
   runtimeConfig: { app: {}, nitro: {} },
-  appConfig: {},
-  appConfigFiles: [],
 
   // Dirs
   scanDirs: [],

src/core/config/resolvers/imports.ts

@@ -63,7 +63,7 @@ function getNitroImportsPreset(): Preset[] {
     },
     {
       from: "nitro/runtime/internal/config",
-      imports: ["useRuntimeConfig", "useAppConfig"],
+      imports: ["useRuntimeConfig"],
     },
     {
       from: "nitro/runtime/internal/plugin",

src/core/config/resolvers/paths.ts

@@ -70,20 +70,6 @@ export async function resolvePathOptions(options: NitroOptions) {
     resolve(options.srcDir, dir)
   );
   options.scanDirs = [...new Set(options.scanDirs)];
-
-  // Normalize app.config file paths
-  options.appConfigFiles ??= [];
-  options.appConfigFiles = options.appConfigFiles
-    .map((file) => _tryResolve(resolveNitroPath(file, options)))
-    .filter(Boolean) as string[];
-
-  // Detect app.config from scanDirs
-  for (const dir of options.scanDirs) {
-    const configFile = _tryResolve("app.config", dir);
-    if (configFile && !options.appConfigFiles.includes(configFile)) {
-      options.appConfigFiles.push(configFile);
-    }
-  }
 }
 
 function _tryResolve(

src/presets/firebase/preset.ts

@@ -39,8 +39,10 @@ const firebase = defineNitroPreset(
           // Using the gen 1 makes this preset backwards compatible for people already using it
           nitro.options.firebase = { gen: 1 };
         }
-        nitro.options.appConfig.nitro = nitro.options.appConfig.nitro || {};
-        nitro.options.appConfig.nitro.firebase = nitro.options.firebase;
+
+        // TODO: add options support back using virtual template
+        // nitro.options.appConfig.nitro = nitro.options.appConfig.nitro || {};
+        // nitro.options.appConfig.nitro.firebase = nitro.options.firebase;
 
         const { serverFunctionName } = nitro.options
           .firebase as FirebaseFunctionsOptions;

src/presets/firebase/runtime/firebase-gen-1.ts

@@ -1,13 +1,13 @@
 import "#nitro-internal-pollyfills";
 import { useNitroApp } from "nitro/runtime";
-import { useAppConfig } from "nitro/runtime";
 
 import functions from "firebase-functions";
 import { toNodeListener } from "h3";
 
 const nitroApp = useNitroApp();
 
-const firebaseConfig = useAppConfig().nitro.firebase;
+// TODO: add options support back using virtual template
+const firebaseConfig = {} as any;
 
 export const __firebaseServerFunctionName__ = functions
   .region(firebaseConfig.region ?? functions.RESET_VALUE)

src/presets/firebase/runtime/firebase-gen-2.ts

@@ -1,13 +1,13 @@
 import "#nitro-internal-pollyfills";
 import { useNitroApp } from "nitro/runtime";
-import { useAppConfig } from "nitro/runtime";
 
 import { onRequest } from "firebase-functions/v2/https";
 import { toNodeListener } from "h3";
 
 const nitroApp = useNitroApp();
 
-const firebaseConfig = useAppConfig().nitro.firebase;
+// TODO: add options support back using virtual template
+const firebaseConfig = {} as any;
 
 export const __firebaseServerFunctionName__ = onRequest(
   {

src/rollup/config.ts

@@ -24,7 +24,6 @@ import { isTest, isWindows } from "std-env";
 import { defineEnv } from "unenv";
 import unimportPlugin from "unimport/unplugin";
 import { rollup as unwasm } from "unwasm/plugin";
-import { appConfig } from "./plugins/app-config";
 import { database } from "./plugins/database";
 import { esbuild } from "./plugins/esbuild";
 import { externals } from "./plugins/externals";
@@ -312,9 +311,6 @@ export const getRollupConfig = (nitro: Nitro): RollupConfig => {
   // Database
   rollupConfig.plugins.push(database(nitro));
 
-  // App.config
-  rollupConfig.plugins.push(appConfig(nitro));
-
   // Handlers
   rollupConfig.plugins.push(handlers(nitro));
 

src/rollup/plugins/app-config.ts

@@ -4,7 +4,7 @@
 export { useNitroApp } from "./internal/app";
 
 // Config
-export { useRuntimeConfig, useAppConfig } from "./internal/config";
+export { useRuntimeConfig } from "./internal/config";
 
 // Storage
 export { useStorage } from "./internal/storage";

src/runtime/index.ts

@@ -1,7 +1,6 @@
 import type { H3Event } from "h3";
 import { klona } from "klona";
 import type { NitroRuntimeConfig } from "nitro/types";
-import { appConfig as _inlineAppConfig } from "#nitro-internal-virtual/app-config";
 import { type EnvOptions, applyEnv } from "./utils.env";
 
 // Static runtime config inlined by nitro build
@@ -38,23 +37,6 @@ export function useRuntimeConfig<
   return runtimeConfig;
 }
 
-// App config
-const _sharedAppConfig = _deepFreeze(klona(_inlineAppConfig));
-export function useAppConfig(event?: H3Event) {
-  // Backwards compatibility with ambient context
-  if (!event) {
-    return _sharedAppConfig;
-  }
-  // Reuse cached app config from event context
-  if (event.context.nitro.appConfig) {
-    return event.context.nitro.appConfig;
-  }
-  // Prepare app config for event context
-  const appConfig = klona(_inlineAppConfig);
-  event.context.nitro.appConfig = appConfig;
-  return appConfig;
-}
-
 // --- Utils ---
 
 function _deepFreeze(object: Record<string, any>) {

src/runtime/internal/config.ts

@@ -51,8 +51,6 @@ export interface NitroOptions extends PresetOptions {
   static: boolean;
   logLevel: LogLevel;
   runtimeConfig: NitroRuntimeConfig;
-  appConfig: AppConfig;
-  appConfigFiles: string[];
 
   // Dirs
   workspaceDir: string;
@@ -280,11 +278,6 @@ export interface LoadConfigOptions {
 // Partial types
 // ------------------------------------------------------------
 
-// App config
-export interface AppConfig {
-  [key: string]: any;
-}
-
 // Public assets
 export interface PublicAssetDir {
   baseURL?: string;

src/types/config.ts

@@ -61,15 +61,10 @@ export default defineNitroConfig({
     "**/_*.txt",
     "!**/_unignored.txt",
   ],
-  appConfig: {
-    "nitro-config": true,
-    dynamic: "initial",
-  },
   runtimeConfig: {
     dynamic: "initial",
     url: "https://{{APP_DOMAIN}}",
   },
-  appConfigFiles: ["~/server.config.ts"],
   publicAssets: [
     {
       baseURL: "build",

test/fixture/middleware/config.ts

@@ -1,13 +1,9 @@
-const sharedAppConfig = useAppConfig();
 const sharedRuntimeConfig = useRuntimeConfig();
 
 export default eventHandler((event) => {
-  const appConfig = useAppConfig(event);
   const runtimeConfig = useRuntimeConfig(event);
 
   return {
-    sharedAppConfig,
-    appConfig,
     runtimeConfig,
     sharedRuntimeConfig,
   };

test/fixture/nitro.config.ts

@@ -547,25 +547,13 @@ export function testNitro(
       url: "/config",
     });
     expect(data).toMatchObject({
-      appConfig: {
-        dynamic: "from-middleware",
-        "app-config": true,
-        "nitro-config": true,
-        "server-config": true,
-      },
       runtimeConfig: {
         dynamic: "from-env",
         url: "https://test.com",
         app: {
           baseURL: "/",
         },
       },
-      sharedAppConfig: {
-        dynamic: "initial",
-        "app-config": true,
-        "nitro-config": true,
-        "server-config": true,
-      },
       sharedRuntimeConfig: {
         // Cloudflare environment variables are set after first request
         dynamic: