merge /bin and /sbin - #666
Conversation
e08b812 to
1fdf6c0
Compare
0fa96ff to
d34d941
Compare
|
Only merged pull requests can be backported. |
|
Now that WSL is open source, should we maybe fix it upstream instead? https://github.com/microsoft/WSL/blob/ae323a4e9b0c1082a1bf1e050df4f88affa9f931/src/linux/init/main.cpp#L87 |
|
I thought this was because usbipd-win hard-coded that path, but I just re-checked and that doesn't seem to be the case: Still I think just merging the two directories would be a good idea. It saves us from creating activation scripts for everything we need to have in /sbin in the future, because we can just use the existing extraBin option |
|
I'd rather get rid of /sbin entirely. |
|
Fair, but then we'd need another way of telling WSL where to look for the init binary. I don't see a good other way to do that. It might be possible through the config file, but not without breaking backwards compatibility for everyone who is still on an older WSL version. I'd be fine with that were it just for something like usbip or docker desktop support, but not with something that's an essential part of the boot code |
|
AFAIUI the open source WSL can install on any supported version no? |
We cannot just change that as other distros have the binary there and relying on PATH maybe opens the next can of worms https://packages.debian.org/search?searchon=contents&keywords=modprobe&mode=path&suite=stable&arch=any |
(cherry picked from commit 87aa106)
|
Successfully created backport PR for |
(cherry picked from commit 87aa106)
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-25.05
git worktree add -d .worktree/backport-666-to-release-25.05 origin/release-25.05
cd .worktree/backport-666-to-release-25.05
git switch --create backport-666-to-release-25.05
git cherry-pick -x 87aa106e089b0b841cd6230a3856cc0bd63827eb |
This will allow us to make files available in
/sbinusingextraBin. usbip needs/sbin/modprobeto loadvhci_hcdon demand