test: run _mysqlcommon unit tests in make + CI; note MariaDB binary requirement

go test ./... skips underscore-prefixed dirs, so internal/driver/_mysqlcommon
unit tests were silently excluded from make test and CI. Name _*-prefixed
packages explicitly so the arg-builder/version tests actually run. Also document
that the MariaDB driver requires the renamed mariadb-dump/mariadb binaries.

Author: nixrajput

.github/workflows/ci.yml

@@ -38,8 +38,10 @@ jobs:
           cache: true
       - name: go vet
         run: go vet ./...
+      # `./...` skips underscore-prefixed dirs, so name _*-prefixed packages
+      # explicitly (e.g. internal/driver/_mysqlcommon) to run their unit tests.
       - name: go test
-        run: go test ./...
+        run: go test ./... ./internal/driver/_*/
       # Integration tests use testcontainers, which needs a Docker daemon.
       # Only ubuntu-latest runners have Docker available by default, so the
       # DB client install and integration suite are scoped to Ubuntu.
@@ -59,4 +61,4 @@ jobs:
           sudo apt-get install -y postgresql-client mysql-client mariadb-client
       - name: Integration tests (Ubuntu only — needs Docker)
         if: matrix.os == 'ubuntu-latest'
-        run: go test -tags=integration ./...
+        run: go test -tags=integration ./... ./internal/driver/_*/

Makefile

@@ -9,14 +9,19 @@ help: ## Show this help
 lint: ## Run golangci-lint
 	golangci-lint run
 
+# NOTE: `go test ./...` skips directories whose names start with `_` (Go tool
+# convention), so underscore-prefixed packages with real tests (e.g.
+# internal/driver/_mysqlcommon) are silently excluded. Name them explicitly via
+# the `_*` glob so their unit tests actually run. The glob auto-picks up any
+# future _*-prefixed package under internal/driver/.
 test: ## Run unit tests
-	go test ./...
+	go test ./... ./internal/driver/_*/
 
 test-verbose: ## Run unit tests verbosely
-	go test -v ./...
+	go test -v ./... ./internal/driver/_*/
 
 test-integration: ## Run integration tests (build tag: integration)
-	go test -tags=integration ./...
+	go test -tags=integration ./... ./internal/driver/_*/
 
 build: ## Build the siphon binary into ./bin
 	@mkdir -p bin

README.md

@@ -64,7 +64,7 @@ A single binary that turns the painful, error-prone sprawl of `pg_dump` → `pg_
 - **Database client tools** — siphon shells out to the native dump/restore tools; it does not embed a client. You only need the tools for the engines you actually use:
   - **PostgreSQL** profiles need `pg_dump`, `pg_restore`, `psql`.
   - **MySQL** profiles need `mysqldump`, `mysql`.
-  - **MariaDB** profiles need `mariadb-dump`, `mariadb`.
+  - **MariaDB** profiles need `mariadb-dump`, `mariadb` (the renamed binaries shipped by MariaDB 10.5+; older installs that only ship `mysqldump`/`mysql` are not yet supported).
 
   | Platform      | PostgreSQL                                                                                                      | MySQL / MariaDB                                       |
   | ------------- | --------------------------------------------------------------------------------------------------------------- | ----------------------------------------------------- |