Note: this issue was drafted by Claude via back-and-forth with @njbrake. The reasoning and decisions are his; the prose is Claude's.
AGENTS.md documents the settings-field wiring required for new SandboxConfig / WorktreeConfig fields. There's no equivalent for adding an agent that uses a custom hook schema (settl, hermes, kiro), even though that path now has five touchpoints:
AGENTS array entry in src/agents.rs (with hook_config: None)
- Sidecar installer + uninstaller in
src/hooks/mod.rs, registered in uninstall_all_hooks
- Host install branch in
install_agent_status_hooks (src/session/instance.rs)
- Tool name added to the env-prefix list in
status_hook_env_prefix (same file)
- Sandbox install branch + volume mount gate in
build_container_config (src/session/container_config.rs)
PR #958's first revision missed step 5, which is exactly the kind of mistake docs would prevent. A short "Adding an agent with a custom hook schema" subsection in AGENTS.md, with a checklist of the five touchpoints and a pointer to install_hermes_hooks as the reference implementation, should be enough.
Pairs naturally with the refactor in #960; if that lands first, the docs section gets shorter.
Note: this issue was drafted by Claude via back-and-forth with @njbrake. The reasoning and decisions are his; the prose is Claude's.
AGENTS.mddocuments the settings-field wiring required for newSandboxConfig/WorktreeConfigfields. There's no equivalent for adding an agent that uses a custom hook schema (settl, hermes, kiro), even though that path now has five touchpoints:AGENTSarray entry insrc/agents.rs(withhook_config: None)src/hooks/mod.rs, registered inuninstall_all_hooksinstall_agent_status_hooks(src/session/instance.rs)status_hook_env_prefix(same file)build_container_config(src/session/container_config.rs)PR #958's first revision missed step 5, which is exactly the kind of mistake docs would prevent. A short "Adding an agent with a custom hook schema" subsection in
AGENTS.md, with a checklist of the five touchpoints and a pointer toinstall_hermes_hooksas the reference implementation, should be enough.Pairs naturally with the refactor in #960; if that lands first, the docs section gets shorter.