fix: recognize valid PMID and legacy arXiv identifiers - #118
Merged
njzjz merged 2 commits intoAug 16, 2026
Conversation
Use full identifier matching, accept historical short PMIDs, and support legacy arXiv identifiers. Agent: ChatGPT Model: GPT-5.6 Sol
Add regression coverage for short PMIDs, legacy/versioned arXiv IDs, and trailing junk. Agent: ChatGPT Model: GPT-5.6 Sol
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #118 +/- ##
=======================================
Coverage 94.41% 94.41%
=======================================
Files 15 15
Lines 949 949
=======================================
Hits 896 896
Misses 53 53 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
njzjz
marked this pull request as ready for review
August 16, 2026 12:28
njzjz
approved these changes
Aug 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Identifier detection used an exact 8-digit PMID regex, only supported the modern arXiv format, and called
match()rather thanfullmatch().Validation
Added focused unit coverage in
tests/test_identifier.py. Full repository CI should run on this PR.Fixes #112
Agent: ChatGPT
Model: GPT-5.6 Sol