chore: fix clippy warnings.

Author: nkaz001

connector/src/bybit/msg.rs

@@ -13,7 +13,7 @@ use crate::utils::{from_str_to_f64, from_str_to_f64_opt, from_str_to_i64};
 
 struct SideVisitor;
 
-impl<'de> Visitor<'de> for SideVisitor {
+impl Visitor<'_> for SideVisitor {
     type Value = Side;
 
     fn expecting(&self, formatter: &mut fmt::Formatter) -> fmt::Result {
@@ -41,7 +41,7 @@ where
 
 struct OrdTypeVisitor;
 
-impl<'de> Visitor<'de> for OrdTypeVisitor {
+impl Visitor<'_> for OrdTypeVisitor {
     type Value = OrdType;
 
     fn expecting(&self, formatter: &mut fmt::Formatter) -> fmt::Result {
@@ -72,7 +72,7 @@ where
 
 struct TimeInForceVisitor;
 
-impl<'de> Visitor<'de> for TimeInForceVisitor {
+impl Visitor<'_> for TimeInForceVisitor {
     type Value = TimeInForce;
 
     fn expecting(&self, formatter: &mut fmt::Formatter) -> fmt::Result {
@@ -102,7 +102,7 @@ where
 
 struct StatusVisitor;
 
-impl<'de> Visitor<'de> for StatusVisitor {
+impl Visitor<'_> for StatusVisitor {
     type Value = Status;
 
     fn expecting(&self, formatter: &mut fmt::Formatter) -> fmt::Result {

connector/src/utils.rs

@@ -22,7 +22,7 @@ use crate::bybit::BybitError;
 
 struct I64Visitor;
 
-impl<'de> Visitor<'de> for I64Visitor {
+impl Visitor<'_> for I64Visitor {
     type Value = Option<i64>;
 
     fn expecting(&self, formatter: &mut fmt::Formatter) -> fmt::Result {
@@ -67,7 +67,7 @@ impl<'de> Visitor<'de> for OptionF64Visitor {
 
 struct F64Visitor;
 
-impl<'de> Visitor<'de> for F64Visitor {
+impl Visitor<'_> for F64Visitor {
     type Value = Option<f64>;
 
     fn expecting(&self, formatter: &mut fmt::Formatter) -> fmt::Result {

hftbacktest/src/backtest/data/mod.rs

@@ -60,12 +60,13 @@ where
     }
 
     pub fn from_data(data: &[D]) -> Self {
-        let byte_len = size_of::<D>() * data.len();
+        let byte_len = size_of_val(data);
         let bytes = unsafe { std::slice::from_raw_parts(data.as_ptr() as *const u8, byte_len) };
 
+        let dest_data_ptr = DataPtr::new(byte_len);
+
         unsafe {
-            let mut dest_data_ptr = DataPtr::new(byte_len);
-            let mut dest_data = dest_data_ptr.ptr.as_mut().expect("data ptr is null");
+            let dest_data = dest_data_ptr.ptr.as_mut().unwrap();
 
             dest_data.copy_from_slice(bytes);
             Self::from_data_ptr(dest_data_ptr, 0)

hftbacktest/src/backtest/proc/l3_local.rs

@@ -1,12 +1,8 @@
-use std::{
-    collections::{hash_map::Entry, HashMap},
-    mem,
-};
+use std::collections::{hash_map::Entry, HashMap};
 
 use crate::{
     backtest::{
         assettype::AssetType,
-        data::{Data, Reader},
         models::{FeeModel, LatencyModel},
         order::OrderBus,
         proc::{LocalProcessor, Processor},
@@ -244,7 +240,7 @@ where
     BacktestError: From<<MD as L3MarketDepth>::Error>,
 {
     fn time_seen(&self, event: &Event) -> Option<i64> {
-        event.is(LOCAL_EVENT).then(|| event.local_ts)
+        event.is(LOCAL_EVENT).then_some(event.local_ts)
     }
 
     fn process(&mut self, ev: &Event) -> Result<(), BacktestError> {

hftbacktest/src/backtest/proc/l3_nopartialfillexchange.rs

@@ -1,9 +1,6 @@
-use std::mem;
-
 use crate::{
     backtest::{
         assettype::AssetType,
-        data::{Data, Reader},
         models::{FeeModel, L3QueueModel, LatencyModel},
         order::OrderBus,
         proc::Processor,
@@ -364,7 +361,7 @@ where
     BacktestError: From<<MD as L3MarketDepth>::Error>,
 {
     fn time_seen(&self, event: &Event) -> Option<i64> {
-        event.is(EXCH_EVENT).then(|| event.exch_ts)
+        event.is(EXCH_EVENT).then_some(event.exch_ts)
     }
 
     fn process(&mut self, event: &Event) -> Result<(), BacktestError> {
@@ -390,17 +387,15 @@ where
             let (prev_best_bid_tick, best_bid_tick) =
                 self.depth
                     .add_buy_order(event.order_id, event.px, event.qty, event.exch_ts)?;
-            self.queue_model
-                .add_market_feed_order(&event, &self.depth)?;
+            self.queue_model.add_market_feed_order(event, &self.depth)?;
             if best_bid_tick > prev_best_bid_tick {
                 self.fill_ask_orders_by_crossing(prev_best_bid_tick, best_bid_tick, event.exch_ts)?;
             }
         } else if event.is(EXCH_ASK_ADD_ORDER_EVENT) {
             let (prev_best_ask_tick, best_ask_tick) =
                 self.depth
                     .add_sell_order(event.order_id, event.px, event.qty, event.exch_ts)?;
-            self.queue_model
-                .add_market_feed_order(&event, &self.depth)?;
+            self.queue_model.add_market_feed_order(event, &self.depth)?;
             if best_ask_tick < prev_best_ask_tick {
                 self.fill_bid_orders_by_crossing(prev_best_ask_tick, best_ask_tick, event.exch_ts)?;
             }
@@ -409,7 +404,7 @@ where
                 self.depth
                     .modify_order(event.order_id, event.px, event.qty, event.exch_ts)?;
             self.queue_model
-                .modify_market_feed_order(event.order_id, &event, &self.depth)?;
+                .modify_market_feed_order(event.order_id, event, &self.depth)?;
             if side == Side::Buy {
                 if best_tick > prev_best_tick {
                     self.fill_ask_orders_by_crossing(prev_best_tick, best_tick, event.exch_ts)?;
@@ -427,7 +422,7 @@ where
             if event.is(BUY_EVENT) || event.is(SELL_EVENT) {
                 let filled = self.queue_model.fill_market_feed_order::<false>(
                     event.order_id,
-                    &event,
+                    event,
                     &self.depth,
                 )?;
                 let timestamp = event.exch_ts;

hftbacktest/src/backtest/proc/local.rs

@@ -238,7 +238,7 @@ where
     FM: FeeModel,
 {
     fn time_seen(&self, event: &Event) -> Option<i64> {
-        event.is(LOCAL_EVENT).then(|| event.local_ts)
+        event.is(LOCAL_EVENT).then_some(event.local_ts)
     }
 
     fn process(&mut self, ev: &Event) -> Result<(), BacktestError> {

hftbacktest/src/backtest/proc/nopartialfillexchange.rs

@@ -2,14 +2,12 @@ use std::{
     cell::RefCell,
     cmp::Ordering,
     collections::{HashMap, HashSet},
-    mem,
     rc::Rc,
 };
 
 use crate::{
     backtest::{
         assettype::AssetType,
-        data::{Data, Reader},
         models::{FeeModel, LatencyModel, QueueModel},
         order::OrderBus,
         proc::Processor,
@@ -655,7 +653,7 @@ where
     FM: FeeModel,
 {
     fn time_seen(&self, event: &Event) -> Option<i64> {
-        event.is(EXCH_EVENT).then(|| event.exch_ts)
+        event.is(EXCH_EVENT).then_some(event.exch_ts)
     }
 
     fn process(&mut self, event: &Event) -> Result<(), BacktestError> {

hftbacktest/src/backtest/proc/partialfillexchange.rs

@@ -2,14 +2,12 @@ use std::{
     cell::RefCell,
     cmp::Ordering,
     collections::{HashMap, HashSet},
-    mem,
     rc::Rc,
 };
 
 use crate::{
     backtest::{
         assettype::AssetType,
-        data::{Data, Reader},
         models::{FeeModel, LatencyModel, QueueModel},
         order::OrderBus,
         proc::Processor,
@@ -857,7 +855,7 @@ where
     FM: FeeModel,
 {
     fn time_seen(&self, event: &Event) -> Option<i64> {
-        event.is(EXCH_EVENT).then(|| event.exch_ts)
+        event.is(EXCH_EVENT).then_some(event.exch_ts)
     }
 
     fn process(&mut self, event: &Event) -> Result<(), BacktestError> {