Fix TfsSharedQueryProcessor to preserve area selection with @CurrentIteration macro #2716
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When migrating queries that use the
@CurrentIteration
macro, theTfsSharedQueryProcessor
fails to preserve area path selections in the migrated query. This results in queries being migrated without any errors but missing their area selection criteria.As shown in the screenshot from the issue, queries with both area selection and
@CurrentIteration
lose their area path condition during migration:Solution
This PR implements a solution that ensures area path conditions are preserved when migrating queries with
@CurrentIteration
macros. The implementation:@CurrentIteration
@CurrentIteration
macroChanges
MigrateQuery
method to capture and log the original query textPreserveMacros
method to handle special macros like@CurrentIteration
Testing
Added unit tests that verify:
@CurrentIteration
and area path selections are properly preserved@CurrentIteration
, they are reordered to ensure preservationFixes #2705.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
crl3.digicert.com
dotnet build
(dns block)crl4.digicert.com
dotnet build
(dns block)ocsp.digicert.com
dotnet build
(dns block)s.symcb.com
dotnet build
(dns block)s.symcd.com
dotnet build
(dns block)ts-crl.ws.symantec.com
dotnet build
(dns block)ts-ocsp.ws.symantec.com
dotnet build
(dns block)www.microsoft.com
dotnet build
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.