refactor(wordpress-seo): drop obsolete fixHomeBreadcrumbs

fixHomeBreadcrumbs only ran when Yoast's get_page_type() returned 'Home_Page' for a PFCPT page. That held in Yoast ~17 (when the logic was first written, late 2021), but Yoast has since moved is_static_posts_page() onto the $wp_query->is_posts_page flag -- which Handler always sets -- and checks it before the Home_Page branch. PFCPT pages now resolve to Static_Posts_Page, so the method is unreachable on every supported Yoast.

Verified against Yoast 25.9 and 27.7, with and without Polylang and with breadcrumbs-home set: all resolve to Static_Posts_Page.

Author: nlemoine

src/Integration/WordPressSeo/Breadcrumbs.php

@@ -8,7 +8,6 @@
 use Yoast\WP\SEO\Context\Meta_Tags_Context;
 use Yoast\WP\SEO\Main;
 use Yoast\WP\SEO\Models\Indexable;
-use Yoast\WP\SEO\Repositories\Indexable_Repository;
 use Yoast\WP\SEO\Surfaces\Values\Meta;
 
 /**
@@ -26,7 +25,6 @@ public function __construct(
 
     public function registerHooks(): void
     {
-        add_filter('wpseo_breadcrumb_indexables', [$this, 'fixHomeBreadcrumbs'], 10, 2);
         add_filter('wpseo_breadcrumb_indexables', [$this, 'fixTaxonomyBreadcrumbs'], 10, 2);
         add_filter('wpseo_breadcrumb_indexables', [$this, 'fixPostBreadcrumbs'], 10, 2);
     }
@@ -125,52 +123,6 @@ public function fixTaxonomyBreadcrumbs(array $indexables, Meta_Tags_Context $con
         return $indexables;
     }
 
-    /**
-     * Fix Yoast breadcrumbs on home.
-     *
-     * @param Indexable[] $indexables
-     * @return Indexable[]
-     */
-    public function fixHomeBreadcrumbs(array $indexables, Meta_Tags_Context $context): array
-    {
-        if (!$this->api->isQueryPageForCustomPostType()) {
-            return $indexables;
-        }
-
-        $yoast = $this->getYoast();
-
-        if ($yoast->helpers->current_page->get_page_type() !== 'Home_Page') {
-            return $indexables;
-        }
-
-        /** @var Indexable_Repository $indexableRepository */
-        $indexableRepository = $yoast->classes->get(Indexable_Repository::class);
-        $staticAncestors = [];
-
-        $breadcrumbsHome = $yoast->helpers->options->get('breadcrumbs-home');
-
-        if ($breadcrumbsHome !== '') {
-            $frontPageId = $yoast->helpers->current_page->get_front_page_id();
-
-            $staticAncestor = $frontPageId === 0
-                ? $indexableRepository->find_for_home_page()
-                : $indexableRepository->find_by_id_and_type($frontPageId, 'post');
-
-            if (
-                $staticAncestor instanceof Indexable
-                && ($frontPageId === 0 || $staticAncestor->post_status !== 'unindexed')
-            ) {
-                $staticAncestors[] = $staticAncestor;
-            }
-        }
-
-        if (!empty($staticAncestors)) {
-            array_unshift($indexables, ...$staticAncestors);
-        }
-
-        return $indexables;
-    }
-
     private function getYoast(): Main
     {
         /** @var Main */