Minor consistency improvements (idaholab#32781)

Author: nmnobre

framework/src/mfem/indicators/MFEML2ZienkiewiczZhuIndicator.C

@@ -28,27 +28,13 @@ MFEML2ZienkiewiczZhuIndicator::validParams()
 MFEML2ZienkiewiczZhuIndicator::MFEML2ZienkiewiczZhuIndicator(const InputParameters & params)
   : MFEMIndicator(params)
 {
-  if (isParamSetByUser("flux_fespace"))
-  {
-    // fetch the flux_fespace from the object system
-    auto object_ptr =
-        getMFEMProblem()
-            .getMFEMObject<MFEMFESpace>("MFEMFESpace", getParam<MFEMFESpaceName>("flux_fespace"))
-            .getSharedPtr();
-    auto fespace_ptr = std::dynamic_pointer_cast<const MFEMFESpace>(object_ptr);
-    _flux_fes = fespace_ptr->getFESpace();
-  }
+  // fetch the flux_fespace from the object system
+  if (auto * sn = queryParam<MFEMFESpaceName>("flux_fespace"))
+    _flux_fes = getMFEMProblem().getMFEMObject<MFEMFESpace>("MFEMFESpace", *sn).getFESpace();
 
-  if (isParamSetByUser("smooth_flux_fespace"))
-  {
-    // fetch the smooth_flux_fespace from the object system
-    auto object_ptr = getMFEMProblem()
-                          .getMFEMObject<MFEMFESpace>(
-                              "MFEMFESpace", getParam<MFEMFESpaceName>("smooth_flux_fespace"))
-                          .getSharedPtr();
-    auto fespace_ptr = std::dynamic_pointer_cast<const MFEMFESpace>(object_ptr);
-    _smooth_flux_fes = fespace_ptr->getFESpace();
-  }
+  // fetch the smooth_flux_fespace from the object system
+  if (auto * sn = queryParam<MFEMFESpaceName>("smooth_flux_fespace"))
+    _smooth_flux_fes = getMFEMProblem().getMFEMObject<MFEMFESpace>("MFEMFESpace", *sn).getFESpace();
 }
 
 void

framework/src/mfem/postprocessors/MFEMPostprocessor.C

@@ -16,7 +16,6 @@ MFEMPostprocessor::validParams()
 {
   InputParameters params = MFEMExecutedObject::validParams();
   params += Postprocessor::validParams();
-  params.registerSystemAttributeName("MFEMExecutedObject");
   return params;
 }
 

framework/src/mfem/problem/MFEMProblem.C

@@ -10,15 +10,11 @@
 #ifdef MOOSE_MFEM_ENABLED
 
 #include "MFEMProblem.h"
-#include "MFEMInitialCondition.h"
 #include "MFEMVariable.h"
 #include "MFEMIndicator.h"
 #include "MFEMSubMesh.h"
 #include "MFEMFunctorMaterial.h"
-#include "MFEMSubMeshTransfer.h"
 #include "MFEMExecutedObject.h"
-#include "Postprocessor.h"
-#include "VectorPostprocessor.h"
 #include "MFEMVectorUtils.h"
 #include "libmesh/string_to_enum.h"
 
@@ -56,7 +52,7 @@ MFEMProblem::MFEMProblem(const InputParameters & params)
 void
 MFEMProblem::initialSetup()
 {
-  FEProblemBase::initialSetup();
+  ExternalProblem::initialSetup();
 
   // MFEM indicators create their estimators during addIndicator(); markers still need an explicit
   // setup pass because they are no longer initialized through the libMesh/MOOSE user-object path.
@@ -72,7 +68,7 @@ MFEMProblem::execute(const ExecFlagType & exec_type)
   setCurrentExecuteOnFlag(exec_type);
   executeMFEMObjects(exec_type);
 
-  FEProblemBase::execute(exec_type);
+  ExternalProblem::execute(exec_type);
 }
 
 void
@@ -260,7 +256,7 @@ MFEMProblem::addGridFunction(const std::string & var_type,
   else
   {
     // Add MOOSE variable.
-    FEProblemBase::addVariable(var_type, var_name, parameters);
+    ExternalProblem::addVariable(var_type, var_name, parameters);
 
     // Add MFEM variable indirectly ("gridfunction").
     InputParameters mfem_variable_params = addMFEMFESpaceFromMOOSEVariable(parameters);
@@ -539,7 +535,7 @@ MFEMProblem::addVectorPostprocessor(const std::string & type,
     addObject<MFEMExecutedObject>(type, name, parameters);
   }
   else
-    FEProblemBase::addVectorPostprocessor(type, name, parameters);
+    ExternalProblem::addVectorPostprocessor(type, name, parameters);
 }
 
 InputParameters
@@ -688,7 +684,7 @@ MFEMProblem::addTransfer(const std::string & transfer_name,
   if (parameters.getBase() == "MFEMSubMeshTransfer")
     addObject<MFEMExecutedObject>(transfer_name, name, parameters);
   else
-    FEProblemBase::addTransfer(transfer_name, name, parameters);
+    ExternalProblem::addTransfer(transfer_name, name, parameters);
 }
 
 void

framework/src/mfem/vectorpostprocessors/MFEMVectorPostprocessor.C

@@ -16,7 +16,6 @@ MFEMVectorPostprocessor::validParams()
 {
   InputParameters params = MFEMExecutedObject::validParams();
   params += VectorPostprocessor::validParams();
-  params.registerSystemAttributeName("MFEMExecutedObject");
   return params;
 }