commands: fix validation of string and zlib

nmoroze · nmoroze · commit 3a5ff82abe30 · 2026-01-02T20:11:28.000-05:00
diff --git a/src/tclint/commands/builtin.py b/src/tclint/commands/builtin.py
@@ -1155,7 +1155,7 @@ def _while(args, parser):
     "source": check_count("source", 1, 3),
     "split": check_count("split", 1, 2),
     # TODO: check subcommands
-    "string": check_count("string", 2, None),
+    "string": check_count("string", 1, None),
     "subst": check_count("subst", 1, 4),
     "switch": _switch,
     "tailcall": check_count("tailcall", 1, None),
@@ -1201,5 +1201,5 @@ def _while(args, parser):
         ]
     },
     # TODO: check subcommands
-    "zlib": check_count("zlib", 3, None),
+    "zlib": check_count("zlib", 2, None),
 })
diff --git a/tests/commands/test_builtins.py b/tests/commands/test_builtins.py
@@ -21,6 +21,8 @@
         ("foreach", False),
         (r"foreach $iters {}", False),
         ("after cancel", False),
+        ('zlib decompress "hello"', True),
+        ("string cat", True),
     ],
 )
 def test_validation(command, valid):

Original file line number	Diff line number	Diff line change
`@@ -21,6 +21,8 @@`
`21`	`21`	`("foreach", False),`
`22`	`22`	`(r"foreach $iters {}", False),`
`23`	`23`	`("after cancel", False),`
	`24`	`+ ('zlib decompress "hello"', True),`
	`25`	`+ ("string cat", True),`
`24`	`26`	`],`
`25`	`27`	`)`
`26`	`28`	`def test_validation(command, valid):`