ci: fix some typecheck issues

Caught by running mypy with --check-untyped-defs.

Claude (the robot) helped a bit with this, but it did some silly things
that didn't match my intent (like annotating `tclfmt.py::check() path:
Optional[pathlib.Path], ...)`, so I had make some tweaks.

There are a few remaining issues to be cleaned up.

Author: nmoroze

src/tclint/checks.py

@@ -119,8 +119,8 @@ def visit_command(self, command):
 
 
 class UnbracedExprChecker(Visitor):
-    def check(self, _, tree, __):
-        self._violations = []
+    def check(self, _, tree, __) -> list[Violation]:
+        self._violations: list[Violation] = []
         tree.accept(self, recurse=True)
         return self._violations
 
@@ -174,8 +174,8 @@ def visit_command(self, command):
 
 
 class RedundantExprChecker(Visitor):
-    def check(self, _, tree, __):
-        self._violations = []
+    def check(self, _, tree, __) -> list[Violation]:
+        self._violations: list[Violation] = []
         tree.accept(self, recurse=True)
         return self._violations
 

src/tclint/cli/tclfmt.py

@@ -45,7 +45,7 @@ def format(
         return formatter.format_top(script, parser)
 
 
-def check(path: pathlib.Path, script: str, formatted: str):
+def check(path: str, script: str, formatted: str):
     parser = Parser()
     original_tree = parser.parse(script)
     formatted_tree = parser.parse(formatted)
@@ -167,7 +167,7 @@ def main():
                 print(formatted, end="")
 
             if args.debug > 0:
-                check(path, script, formatted)
+                check(out_prefix, script, formatted)
         except TclSyntaxError as e:
             line, col = e.start
             print(f"{out_prefix}:{line}:{col}: syntax error: {e}", file=sys.stderr)

src/tclint/cli/tclsp.py

@@ -62,7 +62,7 @@ def lint(source, config, plugin_manager, path):
                     start=start,
                     end=end,
                 ),
-                code=violation.id,
+                code=str(violation.id),
                 source=DIAGNOSTIC_SOURCE,
             )
         )
@@ -443,7 +443,7 @@ def init(ls: TclspServer, params: lsp.InitializeParams):
     capabilities = ls.client_capabilities.workspace
 
     try:
-        ls.client_supports_refresh = (
+        ls.client_supports_refresh = bool(
             capabilities.diagnostics.refresh_support  # type: ignore[union-attr]
         )
     except AttributeError:
@@ -465,7 +465,7 @@ def init(ls: TclspServer, params: lsp.InitializeParams):
         for settings in (ls.global_settings, *ls.workspace_settings.values()):
             if settings.config_file is not None:
                 watchers.append(
-                    lsp.FileSystemWatcher(glob_pattern=settings.config_file)
+                    lsp.FileSystemWatcher(glob_pattern=str(settings.config_file))
                 )
 
         ls.register_capability(

src/tclint/commands/builtin.py

@@ -34,7 +34,7 @@
 
 from tclint.commands.checks import CommandArgError, check_arg_spec, check_count, eval
 from tclint.commands.schema import commands_schema
-from tclint.syntax_tree import BareWord
+from tclint.syntax_tree import BareWord, Node
 
 
 def _check_code(arg):
@@ -432,7 +432,7 @@ def foreach(args, parser):
 def _if(args, parser):
     # ref: https://www.tcl-lang.org/man/tcl8.6/TclCmd/if.htm
 
-    new_args = []
+    new_args: list[Node] = []
 
     # Parse if condition.
     if len(new_args) == len(args):

src/tclint/commands/plugins.py

@@ -6,18 +6,18 @@
 from typing import Optional
 
 import voluptuous
-from importlib_metadata import entry_points
+from importlib_metadata import EntryPoint, entry_points
 
 from tclint.commands import builtin as _builtin
 from tclint.commands import schema
 
 
 class PluginManager:
     def __init__(self, trust_uninstalled=False):
-        self._loaded = {}
-        self._installed = {}
-        self._loaded_specs = {}
-        self._loaded_py = {}
+        self._loaded: dict[str, Optional[dict]] = {}
+        self._installed: dict[str, EntryPoint] = {}
+        self._loaded_specs: dict[pathlib.Path, Optional[dict]] = {}
+        self._loaded_py: dict[pathlib.Path, Optional[dict]] = {}
         for plugin in entry_points(group="tclint.plugins"):
             if plugin.name in self._installed:
                 print(f"Warning: found duplicate definitions for plugin {plugin.name}")