Skip to content

Commit 8b8bb78

Browse files
authored
operator: fix handicapped error messages (#1338)
For some reason the current implementation adds context to the error message but forgets to correctly return it. This commit changes this. Signed-off-by: Mat Kowalski <[email protected]>
1 parent ddddd2a commit 8b8bb78

File tree

1 file changed

+4
-8
lines changed

1 file changed

+4
-8
lines changed

controllers/operator/nmstate_controller.go

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -134,23 +134,19 @@ func (r *NMStateReconciler) SetupWithManager(mgr ctrl.Manager) error {
134134

135135
func (r *NMStateReconciler) applyManifests(instance *nmstatev1.NMState, ctx context.Context) error {
136136
if err := r.applyCRDs(instance); err != nil {
137-
errors.Wrap(err, "failed applying CRDs")
138-
return err
137+
return errors.Wrap(err, "failed applying CRDs")
139138
}
140139

141140
if err := r.applyNamespace(instance); err != nil {
142-
errors.Wrap(err, "failed applying Namespace")
143-
return err
141+
return errors.Wrap(err, "failed applying Namespace")
144142
}
145143

146144
if err := r.applyRBAC(instance); err != nil {
147-
errors.Wrap(err, "failed applying RBAC")
148-
return err
145+
return errors.Wrap(err, "failed applying RBAC")
149146
}
150147

151148
if err := r.applyHandler(instance); err != nil {
152-
errors.Wrap(err, "failed applying Handler")
153-
return err
149+
return errors.Wrap(err, "failed applying Handler")
154150
}
155151

156152
isOpenShift, err := cluster.IsOpenShift(r.APIClient)

0 commit comments

Comments
 (0)