From a270ae3926a1ea35894084a3f24ac8c6bc9f30e8 Mon Sep 17 00:00:00 2001 From: Enrique Llorente Date: Tue, 24 Mar 2026 09:29:06 +0100 Subject: [PATCH] fix(e2e): set maxUnavailable to 2 to preserve parallel test coverage After reducing the cluster to 4 nodes (1 control-plane + 3 workers) in #1464, the default maxUnavailable of 50% results in only 1 node (floor(3 * 0.5) = 1), which means the "should be progressing on multiple nodes" test no longer validates parallel processing. Set NMSTATE_MAX_UNAVAILABLE=2 so that 2 out of 3 workers can progress in parallel and 1 is aborted, preserving meaningful coverage of the maxUnavailable logic. Signed-off-by: Enrique Llorente Co-Authored-By: Claude Opus 4.6 (1M context) --- automation/check-patch.e2e-k8s.sh | 1 + test/e2e/handler/utils.go | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/automation/check-patch.e2e-k8s.sh b/automation/check-patch.e2e-k8s.sh index 42066d1636..9f8b029294 100755 --- a/automation/check-patch.e2e-k8s.sh +++ b/automation/check-patch.e2e-k8s.sh @@ -48,6 +48,7 @@ teardown() { main() { export KUBEVIRT_NUM_NODES=4 # 1 control-plane, 3 workers + export NMSTATE_MAX_UNAVAILABLE=2 source automation/check-patch.setup.sh cd ${TMP_PROJECT_PATH} diff --git a/test/e2e/handler/utils.go b/test/e2e/handler/utils.go index d0d3b6eb06..bf5823e26a 100644 --- a/test/e2e/handler/utils.go +++ b/test/e2e/handler/utils.go @@ -718,7 +718,7 @@ func skipIfNotKubernetes() { } func maxUnavailableNodes() int { - m, _ := nmstatenode.ScaledMaxUnavailableNodeCount(len(nodes), intstr.FromString(nmstatenode.DefaultMaxunavailable)) + m, _ := nmstatenode.ScaledMaxUnavailableNodeCount(len(nodes), intstr.FromString(maxUnavailable)) return m }