Skip to content

Example config should have idpCert instead of cert option starting from 5.0.0 #940

Closed
@srd90

Description

@srd90

@node-saml/node-saml 5.0.0 refactored cert to idpCert:

Change has been reflected to @node-saml/passport-saml ADFS related example:

idpCert: 'MIICizCCAfQCCQCY8tKaMc0BMjANBgkqh ... W==',

but it was not reflected to "general" example:

cert: "fake cert", // cert must be provided

Links to codebase point to 5.0.0 version.

Aforementioned minor documentation issue might explain this comment at another issue: node-saml/node-saml#379 (comment)

...
You pointed me to the use of idpcert instead of cert for my MSEntra IDP. FYI: Our users/companies may not (probably won't) all use MSEntra.
...

Comment gave an impression (when combined with other info) that user had interpreted documentation and comments so that MS related IdPs would use idpCert and others cert. Let the record show that node-saml/node-saml#379 should have been discussion and at passport-saml project.

Environment

  • passport-saml version: 5.0.0

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions