Description
@node-saml/node-saml
5.0.0
refactored cert
to idpCert
:
- https://github.com/node-saml/node-saml/blob/v5.0.0/CHANGELOG.md#-major-changes
- Rename
cert
toidpCert
andsigningCert
topublicCert
node-saml#343
Change has been reflected to @node-saml/passport-saml
ADFS related example:
Line 234 in 4d75de4
but it was not reflected to "general" example:
Line 70 in 4d75de4
Links to codebase point to 5.0.0
version.
Aforementioned minor documentation issue might explain this comment at another issue: node-saml/node-saml#379 (comment)
...
You pointed me to the use of idpcert instead of cert for my MSEntra IDP. FYI: Our users/companies may not (probably won't) all use MSEntra.
...
Comment gave an impression (when combined with other info) that user had interpreted documentation and comments so that MS related IdPs would use idpCert
and others cert
. Let the record show that node-saml/node-saml#379 should have been discussion and at passport-saml
project.
Environment
passport-saml
version: 5.0.0