chore(loader): remove dependency on sucrase (#68)

Author: aduh95

package.json

@@ -14,9 +14,19 @@
     "@types/js-yaml": "^4.0.5",
     "@types/node": "^20.0.0",
     "eslint": "^9.2.0",
-    "typescript": "^5.1.3",
+    "typescript": "^5.8.3",
     "typescript-eslint": "^8.34.0"
   },
+  "devEngines": {
+    "packageManager": {
+      "name": "yarn",
+      "version": "4.9.2"
+    },
+    "runtime": {
+      "name": "nodejs",
+      "version": ">=22.6.0"
+    }
+  },
   "imports": {
     "#ts-loader": "./packages/ts-loader/loader.js"
   },

packages/core/src/countBallotsFromGit.ts

@@ -12,7 +12,7 @@ import decryptData from "@node-core/caritat-crypto/decrypt";
 import reconstructSplitKey from "@node-core/caritat-crypto/reconstructSplitKey";
 import type { VoteCommit } from "./vote.js";
 import Vote from "./vote.js";
-import { DiscardedCommit } from "./summary/electionSummary.js";
+import type { DiscardedCommit } from "./summary/electionSummary.js";
 import type VoteResult from "./votingMethods/VoteResult.js";
 import { getGPGSignGitFlag } from "./utils/gpgSign.js";
 

packages/core/src/generateNewVoteFolder.ts

@@ -9,7 +9,7 @@ import { env } from "node:process";
 import * as yaml from "js-yaml";
 
 import { generateAndSplitKeyPair } from "@node-core/caritat-crypto/generateSplitKeyPair";
-import { loadYmlString, templateBallot, VoteFileFormat } from "./parser.js";
+import { loadYmlString, templateBallot, type VoteFileFormat } from "./parser.js";
 import runChildProcessAsync from "./utils/runChildProcessAsync.js";
 import type { VoteMethod } from "./vote.js";
 

packages/core/src/parser.ts

@@ -1,7 +1,7 @@
 import * as yaml from "js-yaml";
 import * as fs from "fs";
 import * as crypto from "crypto";
-import { VoteMethod } from "./vote.js";
+import type { VoteMethod } from "./vote.js";
 
 export interface VoteFileFormat {
   candidates: string[];

packages/core/src/summary/condorcetSummary.ts

@@ -1,4 +1,4 @@
-import { Ballot, VoteCandidate } from "../vote";
+import type { Ballot, VoteCandidate } from "../vote";
 import cleanMarkdown from "../utils/cleanMarkdown.js";
 import ElectionSummary from "./electionSummary.js";
 

packages/core/src/vote.ts

@@ -1,17 +1,17 @@
 import {
-  BallotFileFormat,
+  type BallotFileFormat,
   checkBallot,
   loadYmlFile,
   loadYmlString,
   parseYml,
-  VoteFileFormat,
+  type VoteFileFormat,
 } from "./parser.js";
 import type { PathOrFileDescriptor } from "fs";
 import type { CandidateScores } from "./votingMethods/VotingMethodImplementation.js";
 import VoteResult from "./votingMethods/VoteResult.js";
 import CondorcetResult from "./votingMethods/CondorcetResult.js";
 import SingleRoundResult from "./votingMethods/SingleRoundResult.js";
-import { ElectionSummaryOptions } from "./summary/electionSummary.js";
+import type { ElectionSummaryOptions } from "./summary/electionSummary.js";
 
 export interface Actor {
   id: string;
@@ -85,13 +85,13 @@ export default class Vote {
   public loadFromFile(voteFilePath: PathOrFileDescriptor): void {
     const voteData: VoteFileFormat = loadYmlFile<VoteFileFormat>(voteFilePath);
     this.voteFromVoteData(voteData);
-  }
+  }
 
   public loadFromString(voteFileContents: string): void {
     const voteData: VoteFileFormat
       = loadYmlString<VoteFileFormat>(voteFileContents);
     this.voteFromVoteData(voteData);
-  }
+  }
 
   private voteFromVoteData(voteData: VoteFileFormat) {
     this.voteFileData = voteData;

packages/core/src/voteUsingGit.ts

@@ -10,11 +10,11 @@ import { getGPGSignGitFlag } from "./utils/gpgSign.js";
 
 import encryptData from "@node-core/caritat-crypto/encrypt";
 import {
-  BallotFileFormat,
+  type BallotFileFormat,
   loadYmlFile,
   parseYml,
   templateBallot,
-  VoteFileFormat,
+  type VoteFileFormat,
 } from "./parser.js";
 import {
   getSummarizedBallot,

packages/core/test/winner.test.ts

@@ -1,7 +1,7 @@
 import it from "node:test";
 import { strict as assert } from "node:assert";
 
-import { VoteCandidate } from "../src/vote.js";
+import type { VoteCandidate } from "../src/vote.js";
 import VoteResult from "../src/votingMethods/VoteResult.js";
 import type { CandidateScores } from "../src/votingMethods/VoteResult";
 

packages/ts-loader/loader.js

@@ -1,7 +1,6 @@
 import { readFile, opendir } from "node:fs/promises";
-import { URL, fileURLToPath } from "node:url";
-
-import { transform } from "sucrase";
+import process from "node:process";
+import { URL } from "node:url";
 
 /**
  * Maps all the possible import specifier to the absolute URL of the source file.
@@ -95,18 +94,11 @@ export async function resolve(urlStr, context, next) {
 }
 
 export async function load(urlStr, context, next) {
-  const url = new URL(urlStr);
-  if (url.pathname.endsWith(".ts")) {
-    const { source } = await next(urlStr, { ...context, format: "module" });
-    return {
-      source: transform(source.toString("utf-8"), {
-        transforms: ["typescript"],
-        disableESTransforms: true,
-        filePath: fileURLToPath(url),
-      }).code,
-      format: "module",
-    };
-  } else {
-    return next(urlStr, context);
+  if (!process.features.typescript) {
+    const url = new URL(urlStr);
+    if (url.pathname.endsWith(".ts")) {
+      context = { ...context, format: "module-typescript" };
+    }
   }
+  return next(urlStr, context);
 }

packages/ts-loader/package.json

@@ -2,8 +2,5 @@
   "name": "@node-core/caritat-ts-loader",
   "private": true,
   "version": "0.0.0",
-  "type": "module",
-  "dependencies": {
-    "sucrase": "^3.0.0"
-  }
+  "type": "module"
 }