Skip to content

Commit 439e8ae

Browse files
Add detail to helper functions to-do item (#93)
1 parent 207356f commit 439e8ae

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

README.md

+6-2
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,14 @@ This team is spun off from the [Modules team](https://github.com/nodejs/modules)
3030

3131
- [x] Implement chaining as described in the [design](doc/design/proposal-chaining-middleware.md), where the `default<hookName>` becomes `next` and references the next registered hook in the chain. https://github.com/nodejs/node/pull/42623
3232

33-
- [ ] Add helper/utility functions (eg `getPackageType()`) to [`module`](https://nodejs.org/api/module.html) module
34-
3533
- [ ] Move loaders off thread
3634

35+
- [ ] Add helper/utility functions [`module`](https://nodejs.org/api/module.html) module
36+
37+
- [ ] Start with the functions that make up the ESM resolution algorithm as defined in the [spec](https://nodejs.org/api/esm.html#resolver-algorithm-specification). Create helper functions for each of the functions defined in that psuedocode: `esmResolve`, `packageImportsResolve`, `packageResolve`, `esmFileFormat`, `packageSelfResolve`, `readPackageJson`, `packageExportsResolve`, `lookupPackageScope`, `packageTargetResolve`, `packageImportsExportsResolve`, `patternKeyCompare`. (Not necessarily all with these exact names, but corresponding to these functions from the spec.)
38+
39+
- [ ] Follow up with similar helper functions that make up what happens within Node’s internal `load`. (Definitions to come.)
40+
3741
- [ ] Support loading source when the return value of `load` has `format: 'commonjs'`. See https://github.com/nodejs/node/issues/34753#issuecomment-735921348 and https://github.com/nodejs/loaders-test/blob/835506a638c6002c1b2d42ab7137db3e7eda53fa/coffeescript-loader/loader.js#L45-L50.
3842

3943
- [ ] First-class support for [import maps](https://github.com/WICG/import-maps) that doesn’t require a custom loader.

0 commit comments

Comments
 (0)