From f2ad2321b75ca6753361361557b914b38d1c284f Mon Sep 17 00:00:00 2001
From: Ruy Adorno <ruy@vlt.sh>
Date: Wed, 8 Jan 2025 10:38:03 -0500
Subject: [PATCH] chore(git-node): add make lint-md reminder

After two consecutive releases in which I mistakely pushed a broken
release commit to main, I'm convinced that the process needs
improvement.

This changeset proposes to add a reminder to `git node release promote`
to lint markdown files prior to pushing branches to upstream remote.

Refs: https://github.com/nodejs/node/commit/a344300bfa146fce9d1f20a71b073263a4720eab
Refs: https://github.com/nodejs/node/pull/56508
---
 lib/promote_release.js | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/lib/promote_release.js b/lib/promote_release.js
index d717110f..c524a307 100644
--- a/lib/promote_release.js
+++ b/lib/promote_release.js
@@ -195,6 +195,12 @@ export default class ReleasePromotion extends Session {
       }
     }
 
+    cli.separator();
+    cli.warn('Reminder: Lint markdown files');
+    cli.info('You might need to amend the commit if there are issues:');
+    cli.info('make lint-md');
+    cli.separator();
+
     // Push to the remote the release tag, and default, release, and staging branch.
     await this.pushToRemote(workingOnNewReleaseCommit);