test_runner: set level for coverage threshold

hpatel292-seneca · hpatel292-seneca · commit 1ca0d45f06f4 · 2024-11-23T19:06:35.000-05:00
Updated coverage threshold checks in to use the parameter when calling. Errors now use the 'error' level for red-colored formatting. This ensures coverage errors are highlighted effectively in the output. Fixes: #55922
diff --git a/lib/internal/test_runner/test.js b/lib/internal/test_runner/test.js
@@ -1087,7 +1087,7 @@ class Test extends AsyncResource {
           if (actual < threshold) {
             harness.success = false;
             process.exitCode = kGenericUserError;
-            reporter.diagnostic(nesting, loc, `Error: ${NumberPrototypeToFixed(actual, 2)}% ${name} coverage does not meet threshold of ${threshold}%.`);
+            reporter.diagnostic(nesting, loc, `Error: ${NumberPrototypeToFixed(actual, 2)}% ${name} coverage does not meet threshold of ${threshold}%.`, 'error');
           }
         }
 

Original file line number	Diff line number	Diff line change
`@@ -1087,7 +1087,7 @@ class Test extends AsyncResource {`
`1087`	`1087`	`if (actual < threshold) {`
`1088`	`1088`	`harness.success = false;`
`1089`	`1089`	`process.exitCode = kGenericUserError;`
`1090`		- reporter.diagnostic(nesting, loc, `Error: ${NumberPrototypeToFixed(actual, 2)}% ${name} coverage does not meet threshold of ${threshold}%.`);
	`1090`	+ reporter.diagnostic(nesting, loc, `Error: ${NumberPrototypeToFixed(actual, 2)}% ${name} coverage does not meet threshold of ${threshold}%.`, 'error');
`1091`	`1091`	`}`
`1092`	`1092`	`}`
`1093`	`1093`