Skip to content

Commit 20c4b80

Browse files
joyeecheungnodejs-github-bot
authored andcommitted
test: skip wasm-allocation tests for pointer compression builds
V8 isolate group initialization forces allocation of the virtual memory cage with pointer compression builds and simply would not work when there is a smaller hard limit on the virtual memory. PR-URL: #58171 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent ac87061 commit 20c4b80

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

test/wasm-allocation/wasm-allocation.status

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,5 +6,5 @@ prefix wasm-allocation
66

77
[true] # This section applies to all platforms
88

9-
[$system!=linux || $asan==on]
9+
[$system!=linux || $asan==on || $pointer_compression==on]
1010
test-wasm-allocation: SKIP

tools/test.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1628,6 +1628,9 @@ def get_asan_state(vm, context):
16281628
asan = Execute([vm, '-p', 'process.config.variables.asan'], context).stdout.strip()
16291629
return "on" if asan == "1" else "off"
16301630

1631+
def get_pointer_compression_state(vm, context):
1632+
pointer_compression = Execute([vm, '-p', 'process.config.variables.v8_enable_pointer_compression'], context).stdout.strip()
1633+
return "on" if pointer_compression == "1" else "off"
16311634

16321635
def Main():
16331636
parser = BuildOptions()
@@ -1726,6 +1729,7 @@ def Main():
17261729
'arch': vmArch,
17271730
'type': get_env_type(vm, options.type, context),
17281731
'asan': get_asan_state(vm, context),
1732+
'pointer_compression': get_pointer_compression_state(vm, context),
17291733
}
17301734
test_list = root.ListTests([], path, context, arch, mode)
17311735
unclassified_tests += test_list

0 commit comments

Comments
 (0)