Skip to content

Commit a6cc240

Browse files
authored
Revert "test: add tests for REPL custom evals"
This reverts commit 1f7cfb7, which was merged into the main branch despite relevant test failures. PR-URL: #57793 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]>
1 parent b92f77a commit a6cc240

File tree

3 files changed

+34
-135
lines changed

3 files changed

+34
-135
lines changed

lib/repl.js

+1
Original file line numberDiff line numberDiff line change
@@ -302,6 +302,7 @@ function REPLServer(prompt,
302302
options.useColors = shouldColorize(options.output);
303303
}
304304

305+
// TODO(devsnek): Add a test case for custom eval functions.
305306
const preview = options.terminal &&
306307
(options.preview !== undefined ? !!options.preview : !eval_);
307308

test/parallel/test-repl-custom-eval.js

-135
This file was deleted.

test/parallel/test-repl-eval.js

+33
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
'use strict';
2+
const common = require('../common');
3+
const assert = require('assert');
4+
const repl = require('repl');
5+
6+
{
7+
let evalCalledWithExpectedArgs = false;
8+
9+
const options = {
10+
eval: common.mustCall((cmd, context) => {
11+
// Assertions here will not cause the test to exit with an error code
12+
// so set a boolean that is checked later instead.
13+
evalCalledWithExpectedArgs = (cmd === 'function f() {}\n' &&
14+
context.foo === 'bar');
15+
})
16+
};
17+
18+
const r = repl.start(options);
19+
r.context = { foo: 'bar' };
20+
21+
try {
22+
// Default preprocessor transforms
23+
// function f() {} to
24+
// var f = function f() {}
25+
// Test to ensure that original input is preserved.
26+
// Reference: https://github.com/nodejs/node/issues/9743
27+
r.write('function f() {}\n');
28+
} finally {
29+
r.write('.exit\n');
30+
}
31+
32+
assert(evalCalledWithExpectedArgs);
33+
}

0 commit comments

Comments
 (0)