src: disable abseil deadlock detection

Abseil deadlock detection is reporting false positives in tests.
Disable it for now.

PR-URL: #57582
Refs: nodejs/node-v8#301
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Stefan Stojanovic <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>

Author: legendecas

node.gyp

@@ -838,6 +838,7 @@
         'deps/googletest/googletest.gyp:gtest_prod',
         'deps/histogram/histogram.gyp:histogram',
         'deps/nbytes/nbytes.gyp:nbytes',
+        'tools/v8_gypfiles/abseil.gyp:abseil',
         'node_js2c#host',
       ],
 
@@ -1160,6 +1161,7 @@
         'deps/googletest/googletest.gyp:gtest_main',
         'deps/histogram/histogram.gyp:histogram',
         'deps/nbytes/nbytes.gyp:nbytes',
+        'tools/v8_gypfiles/abseil.gyp:abseil',
       ],
 
       'includes': [

src/node.cc

@@ -118,6 +118,8 @@
 #include <unistd.h>        // STDIN_FILENO, STDERR_FILENO
 #endif
 
+#include "absl/synchronization/mutex.h"
+
 // ========== global C++ headers ==========
 
 #include <cerrno>
@@ -1224,6 +1226,11 @@ InitializeOncePerProcessInternal(const std::vector<std::string>& args,
 
   if (!(flags & ProcessInitializationFlags::kNoInitializeV8)) {
     V8::Initialize();
+
+    // Disable absl deadlock detection in V8 as it reports false-positive cases.
+    // TODO(legendecas): Replace this global disablement with case suppressions.
+    // https://github.com/nodejs/node-v8/issues/301
+    absl::SetMutexDeadlockDetectionMode(absl::OnDeadlockCycle::kIgnore);
   }
 
   if (!(flags & ProcessInitializationFlags::kNoInitializeCppgc)) {

test/cctest/node_test_fixture.cc

@@ -1,4 +1,5 @@
 #include "node_test_fixture.h"
+#include "absl/synchronization/mutex.h"
 #include "cppgc/platform.h"
 
 ArrayBufferUniquePtr NodeZeroIsolateTestFixture::allocator{nullptr, nullptr};
@@ -31,6 +32,11 @@ void NodeTestEnvironment::SetUp() {
   v8::V8::SetFlagsFromString("--no-freeze-flags-after-init");
 
   v8::V8::Initialize();
+
+  // Disable absl deadlock detection in V8 as it reports false-positive cases.
+  // TODO(legendecas): Replace this global disablement with case suppressions.
+  // https://github.com/nodejs/node-v8/issues/301
+  absl::SetMutexDeadlockDetectionMode(absl::OnDeadlockCycle::kIgnore);
 }
 
 void NodeTestEnvironment::TearDown() {

tools/v8_gypfiles/abseil.gyp

@@ -267,6 +267,8 @@
         '<(ABSEIL_ROOT)/absl/synchronization/internal/waiter.h',
         '<(ABSEIL_ROOT)/absl/synchronization/internal/waiter_base.h',
         '<(ABSEIL_ROOT)/absl/synchronization/internal/waiter_base.cc',
+        '<(ABSEIL_ROOT)/absl/synchronization/internal/win32_waiter.h',
+        '<(ABSEIL_ROOT)/absl/synchronization/internal/win32_waiter.cc',
         '<(ABSEIL_ROOT)/absl/synchronization/mutex.h',
         '<(ABSEIL_ROOT)/absl/synchronization/mutex.cc',
         '<(ABSEIL_ROOT)/absl/time/civil_time.h',