lib: fix realpathSync resolving to invalid path

CGQAQ · CGQAQ · commit beddb4be2032 · 2024-08-21T11:40:53.000+08:00
diff --git a/lib/fs.js b/lib/fs.js
@@ -2731,6 +2731,14 @@ function realpathSync(p, options) {
       }
       resolvedLink = pathModule.resolve(previous, linkTarget);
 
+      // If resolvedLink is not valid or is a pipe/socket, stop resolving, break out of the loop
+      // issue: https://github.com/nodejs/node/issues/54200
+      const resolvedLinkStats = binding.lstat(resolvedLink, false, undefined, false /* throwIfNoEntry */);
+      if (!resolvedLinkStats || isFileType(resolvedLinkStats, S_IFIFO) ||
+        isFileType(resolvedLinkStats, S_IFSOCK)) {
+        break;
+      }
+
       cache?.set(base, resolvedLink);
       if (!isWindows) seenLinks.set(id, linkTarget);
     }

Original file line number	Diff line number	Diff line change
`@@ -2731,6 +2731,14 @@ function realpathSync(p, options) {`
`2731`	`2731`	`}`
`2732`	`2732`	`resolvedLink = pathModule.resolve(previous, linkTarget);`
`2733`	`2733`
	`2734`	`+ // If resolvedLink is not valid or is a pipe/socket, stop resolving, break out of the loop`
	`2735`	`+ // issue: https://github.com/nodejs/node/issues/54200`
	`2736`	`+ const resolvedLinkStats = binding.lstat(resolvedLink, false, undefined, false /* throwIfNoEntry */);`
	`2737`	`+ if (!resolvedLinkStats \|\| isFileType(resolvedLinkStats, S_IFIFO) \|\|`
	`2738`	`+ isFileType(resolvedLinkStats, S_IFSOCK)) {`
	`2739`	`+ break;`
	`2740`	`+ }`
	`2741`	`+`
`2734`	`2742`	`cache?.set(base, resolvedLink);`
`2735`	`2743`	`if (!isWindows) seenLinks.set(id, linkTarget);`
`2736`	`2744`	`}`