From c697c14c77016e9d8f0b0ebf10b50b72315edea9 Mon Sep 17 00:00:00 2001 From: JonasBa Date: Fri, 7 Mar 2025 10:29:21 -0500 Subject: [PATCH] tls: remove deprecated tls.createSecurePair --- benchmark/tls/secure-pair.js | 16 +- doc/api/deprecations.md | 5 +- doc/api/tls.md | 12 -- lib/internal/tls/secure-pair.js | 87 -------- lib/tls.js | 6 - test/parallel/test-tls-basic-validations.js | 9 - test/parallel/test-tls-external-accessor.js | 6 - test/parallel/test-tls-handshake-nohang.js | 32 --- test/parallel/test-tls-legacy-deprecated.js | 15 -- test/parallel/test-tls-securepair-fiftharg.js | 25 --- test/parallel/test-tls-securepair-leak.js | 28 --- test/parallel/test-tls-securepair-server.js | 149 -------------- ...t-tls-socket-snicallback-without-server.js | 3 - test/root.status | 1 - test/sequential/test-tls-securepair-client.js | 191 ------------------ 15 files changed, 5 insertions(+), 580 deletions(-) delete mode 100644 lib/internal/tls/secure-pair.js delete mode 100644 test/parallel/test-tls-handshake-nohang.js delete mode 100644 test/parallel/test-tls-legacy-deprecated.js delete mode 100644 test/parallel/test-tls-securepair-fiftharg.js delete mode 100644 test/parallel/test-tls-securepair-leak.js delete mode 100644 test/parallel/test-tls-securepair-server.js delete mode 100644 test/sequential/test-tls-securepair-client.js diff --git a/benchmark/tls/secure-pair.js b/benchmark/tls/secure-pair.js index 1c5dd732d1ca9e..a253bbf0260733 100644 --- a/benchmark/tls/secure-pair.js +++ b/benchmark/tls/secure-pair.js @@ -2,7 +2,7 @@ const common = require('../common.js'); const bench = common.createBenchmark(main, { dur: [5], - securing: ['SecurePair', 'TLSSocket', 'clear'], + securing: ['TLSSocket', 'clear'], size: [100, 1024, 1024 * 1024], }, { flags: ['--no-warnings'], @@ -68,9 +68,6 @@ function main({ dur, size, securing }) { function onProxyConnection(conn) { const client = net.connect(REDIRECT_PORT, () => { switch (securing) { - case 'SecurePair': - securePair(conn, client); - break; case 'TLSSocket': secureTLSSocket(conn, client); break; @@ -83,17 +80,6 @@ function main({ dur, size, securing }) { }); } - function securePair(conn, client) { - const serverCtx = tls.createSecureContext(options); - const serverPair = tls.createSecurePair(serverCtx, true, true, false); - conn.pipe(serverPair.encrypted); - serverPair.encrypted.pipe(conn); - serverPair.on('error', (error) => { - throw new Error(`Pair error: ${error}`); - }); - serverPair.cleartext.pipe(client); - } - function secureTLSSocket(conn, client) { const serverSocket = new tls.TLSSocket(conn, options); serverSocket.on('error', (e) => { diff --git a/doc/api/deprecations.md b/doc/api/deprecations.md index 84dc58cfc449df..15315d55db6146 100644 --- a/doc/api/deprecations.md +++ b/doc/api/deprecations.md @@ -1488,6 +1488,9 @@ officially supported API. -Type: Runtime +Type: End-of-Life The `tls.createSecurePair()` API was deprecated in documentation in Node.js 0.11.3. Users should use `tls.Socket` instead. diff --git a/doc/api/tls.md b/doc/api/tls.md index 86644cea76b6a3..4ec51a1b6dba4d 100644 --- a/doc/api/tls.md +++ b/doc/api/tls.md @@ -570,17 +570,6 @@ The `cryptoStream.bytesWritten` property returns the total number of bytes written to the underlying socket _including_ the bytes required for the implementation of the TLS protocol. -## Class: `tls.SecurePair` - - - -> Stability: 0 - Deprecated: Use [`tls.TLSSocket`][] instead. - -Returned by [`tls.createSecurePair()`][]. - ### Event: `'secure'`