src: fix tests and update doc

Author: ilyasShabiCS

doc/api/cli.md

@@ -786,7 +786,35 @@ your environment files.
 node --env-file=.env --env-file-override-local index.js
 ```
 
-To override variables during runtime, use [`process.loadEnvFile({ override: true })`][]
+Example:
+
+Assume you have a local environment variable on your machine
+
+```bash
+API_KEY="local-key"
+```
+
+Meanwhile, your `.env` file contains:
+
+```bash
+API_KEY='env-custom-key'
+```
+
+If you want to use the value from the `.env` file, you should add the
+`--env-file-override-local` flag when running your application.
+This flag requires the use of the `--env-file` flag to load environment files.
+
+```js
+console.log(process.env.API_KEY); // 'env-custom-key'
+```
+
+If you prefer to keep the local value, do not add the
+`--env-file-override-local` flag or avoid providing the override option to
+[`process.loadEnvFile()`][]
+
+```js
+console.log(process.env.API_KEY); // 'local-key'
+```
 
 ### `-e`, `--eval "script"`
 
@@ -3227,7 +3255,7 @@ node --stack-trace-limit=12 -p -e "Error.stackTraceLimit" # prints 12
 [`dnsPromises.lookup()`]: dns.md#dnspromiseslookuphostname-options
 [`import` specifier]: esm.md#import-specifiers
 [`net.getDefaultAutoSelectFamilyAttemptTimeout()`]: net.md#netgetdefaultautoselectfamilyattempttimeout
-[`process.loadEnvFile({ override: true })`]: process.md#processloadenvfilepath-options
+[`process.loadEnvFile()`]: process.md#processloadenvfilepath-options
 [`process.setUncaughtExceptionCaptureCallback()`]: process.md#processsetuncaughtexceptioncapturecallbackfn
 [`process.setuid()`]: process.md#processsetuidid
 [`setuid(2)`]: https://man7.org/linux/man-pages/man2/setuid.2.html

doc/api/process.md

@@ -2307,41 +2307,40 @@ changes:
 Loads the `.env` file into `process.env`. Usage of `NODE_OPTIONS`
 in the `.env` file will not have any effect on Node.js.
 
-```cjs
-const { loadEnvFile } = require('node:process');
-loadEnvFile();
-```
-
-```mjs
-import { loadEnvFile } from 'node:process';
-loadEnvFile();
+```js
+process.loadEnvFile();
 ```
 
 Override local environment variables using override option
 
-```cjs
-const { loadEnvFile } = require('node:process');
-loadEnvFile('.env', { override: true });
+Example:
+
+Assume you have a local environment variable on your machine
+
+```bash
+API_KEY="local-key"
 ```
 
-```mjs
-import { loadEnvFile } from 'node:process';
-loadEnvFile('.env', { override: true });
+Meanwhile, your `.env` file contains:
+
+```bash
+API_KEY='env-custom-key'
 ```
 
-This API is available through the [`--env-file-override-local`][] flag.
+If you want to use the value from the `.env` file
+
+```js
+process.loadEnvFile('.env', { override: true });
+console.log(process.env.API_KEY); // 'env-custom-key'
+```
 
 Load environment variables with options only
 
-```cjs
-const { loadEnvFile } = require('node:process');
-loadEnvFile({ override: true });
+```js
+process.loadEnvFile({ override: true });
 ```
 
-```mjs
-import { loadEnvFile } from 'node:process';
-loadEnvFile({ override: true });
-```
+This API is available through the [`--env-file-override-local`][] flag.
 
 ## `process.mainModule`
 

src/node_process_methods.cc

@@ -471,9 +471,8 @@ static void ReallyExit(const FunctionCallbackInfo<Value>& args) {
 static void LoadEnvFile(const v8::FunctionCallbackInfo<v8::Value>& args) {
   Environment* env = Environment::GetCurrent(args);
 
-  CHECK_EQ(args.Length(), 2);
+  CHECK_EQ(args.Length(), 2);  // file_path, [should_override]
   CHECK(args[0]->IsString());
-  CHECK(args[1]->IsBoolean());
 
   Utf8Value path_value(args.GetIsolate(), args[0]);
   std::string path = path_value.ToString();

test/parallel/test-process-load-env-file.js

@@ -4,7 +4,7 @@ const common = require('../common');
 const fixtures = require('../../test/common/fixtures');
 const assert = require('node:assert');
 const { describe, it } = require('node:test');
-const { join } = require('node:path');
+const { join, toNamespacedPath } = require('node:path');
 
 const basicValidEnvFilePath = fixtures.path('dotenv/basic-valid.env');
 const validEnvFilePath = fixtures.path('dotenv/valid.env');
@@ -64,7 +64,7 @@ describe('process.loadEnvFile()', () => {
 
       assert.throws(() => {
         process.loadEnvFile();
-      }, { code: 'ENOENT', syscall: 'open', path: '.env' });
+      }, { code: 'ENOENT', syscall: 'open', path: toNamespacedPath('.env') });
     } finally {
       if (common.isMainThread) {
         process.chdir(originalCwd);
@@ -106,10 +106,9 @@ describe('process.loadEnvFile()', () => {
   });
 });
 
-describe('process.loadEnvFile(path, { override: true })', () => {
+describe('process.loadEnvFile(path, options)', () => {
 
   it('should not override the original value', async () => {
-    process.env.BASIC = 'Original value';
     const code = `
       process.loadEnvFile(${JSON.stringify(validEnvFilePath)});
       const assert = require('assert');
@@ -118,39 +117,39 @@ describe('process.loadEnvFile(path, { override: true })', () => {
     const child = await common.spawnPromisified(
       process.execPath,
       [ '--eval', code ],
-      { cwd: __dirname },
+      { cwd: __dirname, env: { ...process.env, BASIC: 'Original value' } },
     );
     assert.strictEqual(child.stderr, '');
     assert.strictEqual(child.code, 0);
   });
 
   it('should override the original value', async () => {
-    process.env.BASIC = 'Original value';
     const code = `
-      process.loadEnvFile(${JSON.stringify(validEnvFilePath)}, {override: true});
       const assert = require('assert');
+      assert.strictEqual(process.env.BASIC, 'Original value');
+      process.loadEnvFile(${JSON.stringify(validEnvFilePath)}, {override: true});
       assert.strictEqual(process.env.BASIC, 'basic');
     `.trim();
     const child = await common.spawnPromisified(
       process.execPath,
       [ '--eval', code ],
-      { cwd: __dirname },
+      { cwd: __dirname, env: { ...process.env, BASIC: 'Original value' } },
     );
     assert.strictEqual(child.stderr, '');
     assert.strictEqual(child.code, 0);
   });
 
   it('supports passing options only', async () => {
-    process.env.BASIC = 'Original value';
     const code = `
-      process.loadEnvFile({override: true});
       const assert = require('assert');
+      assert.strictEqual(process.env.BASIC, 'Original value');
+      process.loadEnvFile({override: true});
       assert.strictEqual(process.env.BASIC, 'basic');
     `.trim();
     const child = await common.spawnPromisified(
       process.execPath,
       [ '--eval', code ],
-      { cwd: fixtures.path('dotenv/') },
+      { cwd: fixtures.path('dotenv/'), env: { ...process.env, BASIC: 'Original value' } },
     );
     assert.strictEqual(child.stderr, '');
     assert.strictEqual(child.code, 0);