Skip to content

Commit d86ff60

Browse files
hkleungaitargos
authored andcommitted
http2: remove no longer userful options.selectPadding
This is a followup cleanup on a previous PR. Current source code and doc explicitly states that `selectPadding` has been removed for all exports. Refs: #29144 Refs: https://nodejs.org/api/http2.html PR-URL: #58373 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 4606a67 commit d86ff60

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

lib/internal/http2/core.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,6 @@ const kPendingRequestCalls = Symbol('kPendingRequestCalls');
247247
const kProceed = Symbol('proceed');
248248
const kRemoteSettings = Symbol('remote-settings');
249249
const kRequestAsyncResource = Symbol('requestAsyncResource');
250-
const kSelectPadding = Symbol('select-padding');
251250
const kSentHeaders = Symbol('sent-headers');
252251
const kSentTrailers = Symbol('sent-trailers');
253252
const kServer = Symbol('server');
@@ -1100,8 +1099,6 @@ function setupHandle(socket, type, options) {
11001099
const handle = new binding.Http2Session(type);
11011100
handle[kOwner] = this;
11021101

1103-
if (typeof options.selectPadding === 'function')
1104-
this[kSelectPadding] = options.selectPadding;
11051102
handle.consume(socket._handle);
11061103
handle.ongracefulclosecomplete = this[kMaybeDestroy].bind(this, null);
11071104

0 commit comments

Comments
 (0)