Skip to content

Commit eaab206

Browse files
committed
Refactor fixtures from globalPreload to register/initialize
1 parent 05095af commit eaab206

File tree

4 files changed

+27
-4
lines changed

4 files changed

+27
-4
lines changed

test/es-module/test-esm-named-exports.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Flags: --no-warnings --experimental-loader ./test/fixtures/es-module-loaders/builtin-named-exports-loader.mjs
1+
// Flags: --import ./test/fixtures/es-module-loaders/builtin-named-exports.mjs
22
'use strict';
33

44
require('../common');

test/es-module/test-esm-named-exports.mjs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Flags: --experimental-loader ./test/fixtures/es-module-loaders/builtin-named-exports-loader.mjs
1+
// Flags: --import ./test/fixtures/es-module-loaders/builtin-named-exports.mjs
22
import '../common/index.mjs';
33
import { readFile, __fromLoader } from 'fs';
44
import assert from 'assert';

test/fixtures/es-module-loaders/builtin-named-exports-loader.mjs

+6-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,11 @@
1-
import module from 'module';
1+
import module from 'node:module';
22
import { readFileSync } from 'node:fs';
33

4-
const GET_BUILTIN = `$__get_builtin_hole_${Date.now()}`;
4+
/** @type {string} */
5+
let GET_BUILTIN;
6+
export function initialize(data) {
7+
GET_BUILTIN = data.GET_BUILTIN;
8+
}
59

610
export async function resolve(specifier, context, next) {
711
const def = await next(specifier, context);
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
import * as fixtures from '../../common/fixtures.mjs';
2+
import { createRequire, register } from 'node:module';
3+
4+
const require = createRequire(import.meta.url);
5+
6+
const GET_BUILTIN = `$__get_builtin_hole_${Date.now()}`;
7+
Object.defineProperty(globalThis, GET_BUILTIN, {
8+
value: (builtinName) => {
9+
return require(builtinName);
10+
},
11+
enumerable: false,
12+
configurable: false,
13+
});
14+
15+
register(fixtures.fileURL('es-module-loaders/builtin-named-exports-loader.mjs'), {
16+
data: {
17+
GET_BUILTIN,
18+
},
19+
});

0 commit comments

Comments
 (0)