[C++ Lint Rule] #define indentation is Inconsistent

[srcmake]

I was recently going through the source code, trying to familiarize myself with the codebase, and I noticed that there's no consistent rule for how #defines are indented.

For example, in node_main.cc, there's no indentation at all in this #ifdef block.

However, in other places, like node.h, there's a space between the # and the define to indicate a kind of indentation.

There also seems to be inconsistency with how many spaces/tabs should go after the #define variable name and the value, as seen here.

Can we come up with a rule for this and add it to the C++ Style Guide? Maybe even add a rule to the linter?

To get started with the rules we can to define, some questions are:

1. Should #defines inside of braces be indented?
2. When should #ifdef X be used vs. if defined(X)?
3. What should the indentation pattern be for #define/#ifdef/#if defined/#ifndef?

[fhinkel]

Thanks for pointing this out.

1. Doesn't matter, as long as it's consistent
2. I prefer #ifdef X because it's shorter, but if we have compound conditionals, we need to go with if defined(X). It'd say let's go with if defined(X) for consistency.
3. Doesn't matter, as long as it's consistent

If anybody wants to take a stab at addling a rule to the linter, that would be great.

[DavenportEmma]

I'll have a go, is this issue still open?

[daltonna]

Is anyone still working on this or is the issue closed? If not can I take a crack at it?