Skip to content

http2 compat missing writableFinished #29230

Open
@ronag

Description

@ronag

http2 compat is missing writableFinished for OutgoingMessage.

I tried fixing this myself but the whole finished flow for http2 compat confuses me.

  • finished seems to be looking at a lot of different stuff (e.g. what does abort have to do with finish?).
  • 'finish' is emitted on stream.on('close', ...).
  • Sometimes we listen to this.on('finish', ...) and sometimes stream.on('finish', ...).

I think someone with a clearer understanding needs to look at this.

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wantedIssues that need assistance from volunteers or PRs that need help to proceed.http2Issues or PRs related to the http2 subsystem.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions