./deps/v8/third_party/zlib instead of the copy in ./deps/zlib ?

[kapouer]

This is not a bug, rather a deduplication idea:
a lot of ./deps/zlib is similar to ./deps/v8/third_party/zlib.

[kapouer]

Oh i forgot: Version 14.4.0

[devsnek]

the copy in v8 isn't locked to our abi requirements, i doubt we could align them

[addaleax]

I think we could make V8 use our vendored dependency, though?

[kapouer]

There could be a single embedded copy (optionally replaced by --shared-zlib) because

• Node doesn't set v8_enable_snapshot_compression: 1
• in 20.x branch, zlib is conditionally used in

  node/deps/v8/src/deoptimizer/translation-array.cc

  Line 11 in aeda72e

  #ifdef V8_USE_ZLIB

• likewise on main:

  node/deps/v8/src/deoptimizer/frame-translation-builder.cc

  Line 11 in fa18378

  #ifdef V8_USE_ZLIB

The following patch disables it completely, and js tests pass with it.

--- a/tools/v8_gypfiles/features.gypi
+++ b/tools/v8_gypfiles/features.gypi
@@ -278,7 +278,7 @@

     # Compile V8 using zlib as dependency.
     # Sets -DV8_USE_ZLIB
-    'v8_use_zlib%': 1,
+    'v8_use_zlib%': 0,

     # Variables from v8.gni

--- a/tools/v8_gypfiles/v8.gyp
+++ b/tools/v8_gypfiles/v8.gyp
@@ -856,7 +856,6 @@
         'run_torque',
         'v8_internal_headers',
         'v8_maybe_icu',
-        'v8_zlib',
         'v8_pch',
       ],
       'includes': ['inspector.gypi'],