Roadmap for stabilization of vm modules

[targos]

According to @SimenB, here are the issues that should probably be taken care of before we unflag and mark vm modules as stable:

• SourceTextModule memory leak (#33439)
• vm.Script's importModuleDynamically should get a reference to the context used to run it (#35714)
• Segmentation fault with import() instead of calling importModuleDynamically (#35889)
• importModuleDynamically for vm module is cached (#36351)
• VM ESM with dynamic imports resolves promises before linking is complete (#33216)
• Change API of module.lnk((specifier) => module) to module.link(specifiers, modules) so that it has fewer C++ -> JS calls and can be reused to implement require(esm).

/cc @devsnek

[SimenB]

That last one might be a bug/race condition in Jest's implementation still. I haven't found the time to dig into it properly since opening up the issue, unfortunately. It feels like it's related to some module caching or context GC thing, but that's pure speculation. I have some hope it's related to whatever needs fixing for #36351 (again, speculating)

[devsnek]

definitely blocked on v8:9968

[SimenB]

The above linked v8 issue has been closed as fixed now (:tada:) - any idea of when we'll know if it's enough for Node's use cases?

[targos]

The commit fixing the above V8 issue is in V8 9.4. I'll probably open a PR upgrading to that version next week.

[devsnek]

it is not fixed quite yet, check v8:10284

[SimenB]

Ah ok, thanks for the link! Seems there's quite a bit of activity recently, so hopefully it's not too far away 🙂