Skip to content

ContextifyContext::PropertyDefinerCallback() never intercepts the request #52634

Open
@isheludko

Description

@isheludko

Version

v22.0.0-pre

Platform

No response

Subsystem

No response

What steps will reproduce the bug?

While migrating Node-ci to a new V8 interceptors Api (https://crrev.com/c/5353146, v8#180) I noticed that ContextifyContext::PropertyDefinerCallback() never reports that it has intercepted the request.
It should have called args.GetReturnValue()->SetUndefined(); in define_prop_on_sandbox instead.

Fixing this issue exposes another one - ContextifyContext::PropertyEnumeratorCallback() never returns symbol properties because ctx->sandbox()->GetPropertyNames(ctx->context()) skips symbols. There's a GetPropertyNames() overload with a PropertyFilter parameter which can be configured to not skip symbols.

How often does it reproduce? Is there a required condition?

No response

What is the expected behavior? Why is that the expected behavior?

No response

What do you see instead?

n/a

Additional information

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    vmIssues and PRs related to the vm subsystem.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions