TypeError: Missing internal module 'node:crypto'

[bncdemo]

Version

v18.20.2

Platform

win10

Subsystem

No response

What steps will reproduce the bug?

I am building node with a vcbuild.bat release x64 static dll command.
node.exe <myapp.js> run as expected, but when I try to do this with the built libnode.dll, I receive:

TypeError: Missing internal module 'node:crypto'

I don't understand. In shared lib mode the internal modules not loaded automatically? (I can run 'regular' scripts with the shared lib without problem)

How often does it reproduce? Is there a required condition?

It happens every time.

What is the expected behavior? Why is that the expected behavior?

No response

What do you see instead?

The code drops an unhandled exception and stop:

process.on('uncaughtException', function(err) {
  console.log(err);
});

->

TypeError: Missing internal module 'node:crypto'

Additional information

No response

[avivkeller]

Thanks for the issue! Could you possibly provide some example code to cause this to occur?

[bncdemo]

Thanks for the issue! Could you possibly provide some example code to cause this to occur?

This single line:

var nc = require("node:crypto");

create the error above.

[avivkeller]

I can't reproduce with my default installation, but it might be a build thing that I haven't done (v22).

> Object.keys(require("node:crypto"))
[
  'checkPrime',
  'checkPrimeSync',
  'createCipheriv',
  'createDecipheriv',
  'createDiffieHellman',
  'createDiffieHellmanGroup',
  'createECDH',
  'createHash',
  'createHmac',
  'createPrivateKey',
  'createPublicKey',
  'createSecretKey',
  'createSign',
  'createVerify',
  'diffieHellman',
  'generatePrime',
  'generatePrimeSync',
  'getCiphers',
  'getCipherInfo',
  'getCurves',
  'getDiffieHellman',
  'getHashes',
  'hkdf',
  'hkdfSync',
  'pbkdf2',
  'pbkdf2Sync',
  'generateKeyPair',
  'generateKeyPairSync',
  'generateKey',
  'generateKeySync',
  'privateDecrypt',
  'privateEncrypt',
  'publicDecrypt',
  'publicEncrypt',
  'randomBytes',
  'randomFill',
  'randomFillSync',
  'randomInt',
  'randomUUID',
  'scrypt',
  'scryptSync',
  'sign',
  'setEngine',
  'timingSafeEqual',
  'getFips',
  'setFips',
  'verify',
  'hash',
  'Certificate',
  'Cipher',
  'Cipheriv',
  'Decipher',
  'Decipheriv',
  'DiffieHellman',
  'DiffieHellmanGroup',
  'ECDH',
  'Hash',
  'Hmac',
  'KeyObject',
  'Sign',
  'Verify',
  'X509Certificate',
  'secureHeapUsed',
  'constants',
  'webcrypto',
  'subtle',
  'getRandomValues'
]

[bncdemo]

I can't reproduce with my default installation, but it might be a build thing that I haven't done (v22).

> Object.keys(require("node:crypto"))
[
  'checkPrime',
  'checkPrimeSync',
  'createCipheriv',
  'createDecipheriv',
  'createDiffieHellman',
  'createDiffieHellmanGroup',
  'createECDH',
  'createHash',
  'createHmac',
  'createPrivateKey',
  'createPublicKey',
  'createSecretKey',
  'createSign',
  'createVerify',
  'diffieHellman',
  'generatePrime',
  'generatePrimeSync',
  'getCiphers',
  'getCipherInfo',
  'getCurves',
  'getDiffieHellman',
  'getHashes',
  'hkdf',
  'hkdfSync',
  'pbkdf2',
  'pbkdf2Sync',
  'generateKeyPair',
  'generateKeyPairSync',
  'generateKey',
  'generateKeySync',
  'privateDecrypt',
  'privateEncrypt',
  'publicDecrypt',
  'publicEncrypt',
  'randomBytes',
  'randomFill',
  'randomFillSync',
  'randomInt',
  'randomUUID',
  'scrypt',
  'scryptSync',
  'sign',
  'setEngine',
  'timingSafeEqual',
  'getFips',
  'setFips',
  'verify',
  'hash',
  'Certificate',
  'Cipher',
  'Cipheriv',
  'Decipher',
  'Decipheriv',
  'DiffieHellman',
  'DiffieHellmanGroup',
  'ECDH',
  'Hash',
  'Hmac',
  'KeyObject',
  'Sign',
  'Verify',
  'X509Certificate',
  'secureHeapUsed',
  'constants',
  'webcrypto',
  'subtle',
  'getRandomValues'
]

Where are you running this exactly? 🤔
Are you using the embedder code

node/test/embedding/embedtest.cc

Line 189 in dc609f5

loadenv_ret = node::LoadEnvironment(

RunNodeInstance --> node::LoadEnvironment() ?

[avivkeller]

I'm running this without the embedder, just the normal REPL. I know it's not the same, but it just verifies that this isn't an issue with the entire Node.js requires.

@nodejs/core I don't think there is an embedders team (the @nodejs/embedders team is for embedding into Electron, etc, right?), if someone knows who to ping that would be helpful!

[bncdemo]

There is some progress. Removing the 'node:' tag make the code running, but I don't want to remove this on long term in every single code:

the test shows the following:

node.exe require('crypto'); -> working
node.exe require('node:crypto'); -> working

libnode.dll require('crypto'); -> working
libnode.dll require('node:crypto'); -> FAIL

Can anybody comment on this? Is there a default namespace 'node' missing from the embedder code? How or where can I set that?

[aduh95]

Any chance the require you're using is not the CJS one but the internal one? What is the value of require.resovle in the context you're using?

[joyeecheung]

(Note that @nodejs/core is not that smaller than the entire collaborators team and is only used for organizational purposes, we don't usually ping it to avoid spamming uninterested people).

If you are using the embedder API, the require you get is the internal one. It doesn't recognize the node: prefix because there is no need, since it has only access to built-ins and internal modules. If you want to use it as the user-land require, do a require('module').createRequire() and use the user-land require it builds instead.

[bncdemo]

require.resovle

node.exe require.resolve: function resolve(request, options) {
validateString(request, 'request');
return Module._resolveFilename(request, mod, false, options);
}

libnode.dll require.resolve: undefined

[avivkeller]

(Note that @nodejs/core is not that smaller than the entire collaborators team and is only used for organizational purposes, we don't usually ping it to avoid spamming uninterested people).

Yikes sorry! Is there a team for this API?

[bncdemo]

(Note that @nodejs/core is not that smaller than the entire collaborators team and is only used for organizational purposes, we don't usually ping it to avoid spamming uninterested people).

If you are using the embedder API, the require you get is the internal one. It doesn't recognize the node: prefix because there is no need, since it has only access to built-ins and internal modules. If you want to use it as the user-land require, do a require('module').createRequire() and use the user-land require it builds instead.

Is there no way to match the regular node.exe context? (from the c++ / embedder side, leaving the nodejs script intact)

[joyeecheung]

It's expected that embedders take the internal require() and do some other stuff of their own before they go on executing a user script, creating a user-land require with require('module').createRequire() and then piping that into the actual user script can be one of those. It's generally not a good idea to directly use the LoadEnvironment API to execute user script because the require() it has access to can access Node.js internals, which is something embedders may need, but users shouldn't do.

[benjamingr]

Yikes sorry! Is there a team for this API?

---@nodejs/embedders--- actually no that's users