Coverity issue 367349: Different smart pointers managing same raw pointer

[targos]

@nodejs/crypto

This may cause a crash, as different smart pointers may try to delete the raw pointer twice.

In node::​crypto::​ManagedX509::​operator =(node::​crypto::​ManagedX509 const &): Same raw pointer is used to initialize or reset two or more different smart pointers.

node/src/crypto/crypto_x509.cc

Lines 57 to 62 in a08129c

	ManagedX509& ManagedX509::operator=(const ManagedX509& that) {
	cert_.reset(that.get());
	if (cert_) [[likely]]
	X509_up_ref(cert_.get());
	return *this;
	}

[jasnell]

Yeah, this one has always bugged. When working in this area recently I wasn't entirely sure how to clean this one up. Right now these are internally ref counted by openssl. I think what we want is that ManagedX509 should effectively become a type of shared_ptr that avoids these kinds of hacks.