`node.config.json` doesn't respect optionally-valued or aliased options

[avivkeller]

Version

v23.11.0

Platform

Microsoft Windows NT 10.0.26100.0 x64

Subsystem

No response

What steps will reproduce the bug?

Create a node.config.json with the following content:

{
  "nodeOptions": {
    "inspect": true
  }
}

Run:

> node --experimental-default-config-file
Unable to resolve "true": unknown node or service

How often does it reproduce? Is there a required condition?

N/A

What is the expected behavior? Why is that the expected behavior?

The expected behavior would be that the configuration file understands that setting a flag to true is the equal to applying node --flag, whereas setting a flag to an alternative value is the equal of applying node --flag=value, even for aliased options.

What do you see instead?

When supplying true,

Unable to resolve "true": unknown node or service

When supplying a string value, like 127.0.0.1:

Invalid value for --inspect
node.config.json: invalid content

Additional information

No response

[geeksilva97]

Inspect option is reaching the boolean case:

node/src/node_config_file.cc

Line 56 in e9b286c

case options_parser::OptionType::kBoolean: {

When a non-boolean is provided, it displays the error Invalid value for --inspect. When providing a boolean, it does this --inspect=true which cannot be interpreted by

node/src/inspector_socket_server.cc

Line 402 in e9b286c

fprintf(out_, "Unable to resolve \"%s\": %s\n", host_.c_str(),

, since whan a value is provided it expects a host:port (https://nodejs.org/api/cli.html#--inspecthostport)

[marco-ippolito]

It expects an hostport value, if you pass any other value it will throw an error

[avivkeller]

It expects an hostport value, if you pass any other value it will throw an error

It should also accept true, to enable inspection on the default port. Regardless, if any non-boolean value is passed, it'll fail validation with node.config.json: invalid content.

Even in the schema it expects a boolean:

"inspect": {
  "type": "boolean"
},

[marco-ippolito]

Probably env_options_map contains the same value twice with different accepted types. This behavior is currently not supported. PR welcome

[geeksilva97]

Will give it a try, folks