Skip to content

doc: spliting building steps for unix and macos #58239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

doc: spliting building steps for unix and macos #58239

wants to merge 1 commit into from

Conversation

vagostep
Copy link

@vagostep vagostep commented May 8, 2025 •
edited
Loading

Currently, there is an error when executing export: CXX=g++-12 on macOS. Without it, it compiles fine. So, we split the step into two caterogies: steps for unix and steps for macOS

Fixes: #58219

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels May 8, 2025
@aduh95
Copy link
Contributor

aduh95 commented May 10, 2025

macOS is not different from other Unix-like system on this point, it's only a matter of whether g++-12 is on your PATH. I don't think it makes sense to split it, maybe we could remove it altogether, I'm not sure this is a good suggestion anyway (a better one would be CXX="ccache c++" IMO).

@vagostep
Copy link
Author

@aduh95 I'm totally open to suggestion about what should it be the best way of document this.

But I don't think my issue is related to the path of g++-12. Because it is throwing the following error:

cc1plus: error: '-Werror=undefined-inline': no option '-Wundefined-inline'; did you mean '-Wundefined-do-loop'?

Maybe if I just move the export CXX=g++-12 part as unix dependency?

@aduh95
Copy link
Contributor

aduh95 commented May 11, 2025

Reading the original issue, it doesn't seem to be Unix-related, but Ubuntu-specific. I suggest we just remove the export, I doubt it's even necessary on Ubuntu.

@vagostep
Copy link
Author

@aduh95 I can confirm that on Ubuntu fails if I don't specify the export CXX. But I'm getting a warning when executing ./configure telling me that I have an older version than g++-12.

I can proceed by deleting only the export line, but for Ubuntu it'll fail :/

@vagostep
Copy link
Author

@aduh95 what about this proposal? I changed the BUILDING.md content.

aduh95
aduh95 reviewed May 15, 2025
View reviewed changes
@vagostep
doc: spliting building steps for unix and macos
d646198 
Currently, there is an error when executing export: CXX=g++-12 on macOS. Without it, it compiles fine. So, we split the step into two caterogies: steps for unix and steps for macOS

Fixes: nodejs#58219

Restoring previous BUILDING.md

new doc proposal for g++-12 export command

removing non related line change

restoring end of file

restoring comment proposal
@vagostep vagostep force-pushed the docs/building-on-mac branch from 6869471 to d646198 Compare May 15, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compiling on Mac cause an error thrown by g++-12
3 participants
@vagostep @aduh95 @nodejs-github-bot