From 3df8851ee9739b4fe6521a414cf356fb5e8ae7e7 Mon Sep 17 00:00:00 2001 From: Jimmy Leung <43258070+hkleungai@users.noreply.github.com> Date: Sun, 18 May 2025 15:35:34 +0800 Subject: [PATCH] http2: remove no longer userful options.selectPadding This is a followup cleanup on a previous PR. Current source code and doc explicitly states that `selectPadding` has been removed for all exports. Refs: https://github.com/nodejs/node/pull/29144 Refs: https://nodejs.org/api/http2.html --- lib/internal/http2/core.js | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/internal/http2/core.js b/lib/internal/http2/core.js index 47c0cb4a9a85cc..5e0dc05c984312 100644 --- a/lib/internal/http2/core.js +++ b/lib/internal/http2/core.js @@ -244,7 +244,6 @@ const kPendingRequestCalls = Symbol('kPendingRequestCalls'); const kProceed = Symbol('proceed'); const kRemoteSettings = Symbol('remote-settings'); const kRequestAsyncResource = Symbol('requestAsyncResource'); -const kSelectPadding = Symbol('select-padding'); const kSentHeaders = Symbol('sent-headers'); const kSentTrailers = Symbol('sent-trailers'); const kServer = Symbol('server'); @@ -1082,8 +1081,6 @@ function setupHandle(socket, type, options) { const handle = new binding.Http2Session(type); handle[kOwner] = this; - if (typeof options.selectPadding === 'function') - this[kSelectPadding] = options.selectPadding; handle.consume(socket._handle); handle.ongracefulclosecomplete = this[kMaybeDestroy].bind(this, null);