Skip to content

riscv64 build failed for v20.11.0 #106

Open
@ehoogeveen-medweb

Description

@ehoogeveen-medweb

I noticed that v20.11.0 isn't listed as an LTS build in index.json. That's probably because the riscv64 build failed, since it means not all platforms would be able to update. I don't use the riscv64 build myself, but our automation looks for the latest LTS and that means it's still stuck on v20.10.0 :)

Build log: https://unofficial-builds.nodejs.org/logs/202401101543-v20.11.0/riscv64.log

The errors look like this:

In file included from ../deps/v8/src/codegen/assembler-arch.h:27,
                 from ../deps/v8/src/wasm/baseline/liftoff-assembler-defs.h:8,
                 from ../deps/v8/src/execution/riscv/frame-constants-riscv.h:11,
                 from ../deps/v8/src/execution/frame-constants.h:426,
                 from ../deps/v8/src/builtins/builtins-utils.h:11,
                 from ../deps/v8/src/api/api-arguments.h:9,
                 from ../deps/v8/src/ic/call-optimization.h:8,
                 from ../deps/v8/src/compiler/heap-refs.h:11,
                 from ../deps/v8/src/compiler/types.h:10,
                 from ../deps/v8/src/compiler/node.h:12,
                 from ../deps/v8/src/compiler/all-nodes.h:8,
                 from ../deps/v8/src/compiler/all-nodes.cc:5:
../deps/v8/src/codegen/riscv/assembler-riscv.h:289:60: error: 'Tagged' has not been declared
  289 |                                                            Tagged<Code> code,
      |                                                            ^~~~~~
../deps/v8/src/codegen/riscv/assembler-riscv.h:289:66: error: expected ',' or '...' before '<' token
  289 |                                                            Tagged<Code> code,
      |                                                                  ^
make[2]: *** [tools/v8_gypfiles/v8_compiler.target.mk:297: /home/node/node-v20.11.0/out/Release/obj.target/v8_compiler/deps/v8/src/compiler/all-nodes.o] Error 1

There are some other errors, but I think they're all a consequence of the above.

Unfortunately I don't know where to go to fix it, where to go to submit a fix or how to test it even if I did, so I hope someone else can have a look!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions