build: add split-debug release and package targets

Add Makefile support for generating separate debug symbol artifacts
from release builds while keeping distributed binaries stripped.

`make release-debug-artifacts` builds `out/Release/nsolid`,
writes `out/Release/nsolid.debug`, strips the release binary,
and adds a debug link back to it.

`make binary SEPARATE_DEBUG_SYMBOLS=1` passes `--debug-symbols`
to `./configure`, strips the packaged `bin/nsolid`, and writes a
separate `$(BINARYNAME).debug` artifact for upload to debuginfod.

`make binary` keeps the previous behavior and does not generate a
separate debug symbol artifact.

Signed-off-by: Santiago Gimeno <santiago.gimeno@gmail.com>

Author: santigimeno

Makefile

@@ -22,6 +22,9 @@ GCOV ?= gcov
 PWD = $(CURDIR)
 BUILD_WITH ?= make
 FIND ?= find
+OBJCOPY ?= objcopy
+STRIP ?= strip
+SEPARATE_DEBUG_SYMBOLS ?= 0
 
 ifdef JOBS
 	PARALLEL_ARGS = -j $(JOBS)
@@ -87,11 +90,23 @@ NODE ?= $(PWD)/$(NODE_EXE)
 # when generating coverage reports or running toolings as
 # debug build is be slower.
 OUT_NODE ?= $(PWD)/out/$(BUILDTYPE)/node$(EXEEXT)
+RELEASE_NODE ?= $(PWD)/out/Release/$(NODE_EXE)
+RELEASE_DEBUG_SYMBOLS ?= $(RELEASE_NODE).debug
+BINARY_DEBUG_SYMBOLS ?= $(BINARYNAME).debug
+
+define split_debug_symbols
+	$(OBJCOPY) --only-keep-debug $(1) $(2)
+	$(STRIP) --strip-debug --strip-unneeded $(1)
+	$(OBJCOPY) --add-gnu-debuglink=$(notdir $(2)) $(1)
+endef
 
 # Flags for packaging.
 BUILD_DOWNLOAD_FLAGS ?= --download=all
 BUILD_INTL_FLAGS ?= --with-intl=full-icu
 BUILD_RELEASE_FLAGS ?= $(BUILD_DOWNLOAD_FLAGS) $(BUILD_INTL_FLAGS)
+ifeq ($(SEPARATE_DEBUG_SYMBOLS),1)
+BUILD_RELEASE_FLAGS += --debug-symbols
+endif
 
 # Default to quiet/pretty builds.
 # To do verbose builds, run `make V=1` or set the V environment variable.
@@ -630,6 +645,13 @@ build-ci: ## Build everything (CI).
 	$(PYTHON) ./configure --verbose $(CONFIG_FLAGS)
 	$(MAKE)
 
+.PHONY: release-debug-artifacts
+release-debug-artifacts: ## Build Release with -g, save debug symbols, and strip the shipped binary.
+	$(PYTHON) ./configure --verbose $(CONFIG_FLAGS) --debug-symbols
+	$(RM) -r out/Release
+	$(MAKE) $(NODE_EXE)
+	$(call split_debug_symbols,$(RELEASE_NODE),$(RELEASE_DEBUG_SYMBOLS))
+
 .PHONY: run-ci
 # Run by CI tests, exceptions:
 # - node-test-commit-arm-fanned (Raspberry Pis), where the binaries are
@@ -1325,6 +1347,9 @@ $(BINARYTAR): release-only
 		--release-urlbase=$(RELEASE_URLBASE) \
 		$(CONFIG_FLAGS) $(BUILD_RELEASE_FLAGS)
 	$(MAKE) install DESTDIR=$(BINARYNAME) V=$(V) PORTABLE=1
+ifeq ($(SEPARATE_DEBUG_SYMBOLS),1)
+	$(call split_debug_symbols,$(BINARYNAME)/bin/$(NODE_EXE),$(BINARY_DEBUG_SYMBOLS))
+endif
 	cp README.md $(BINARYNAME)
 	cp LICENSE $(BINARYNAME)
 	cp LICENSE_NSOLID $(BINARYNAME)