lib,test: fix JS linting errors

Author: santigimeno

lib/internal/nsolid_assets.js

@@ -44,7 +44,7 @@ module.exports = ({ heapProfile: _heapProfile,
    * } catch (err) {
    *   // In case an error happens
    * }
-   * @throws Will throw an error if an error happens and no callback was passed.
+   * @throws {Error} Will throw an error if an error happens and no callback was passed.
    * @function profile
    * @memberof module:nsolid
    */
@@ -93,7 +93,7 @@ module.exports = ({ heapProfile: _heapProfile,
    *     }, 1000);
    *   }
    * });
-   * @throws Will throw an error if an error happens and no callback was passed.
+   * @throws {Error} Will throw an error if an error happens and no callback was passed.
    * @function profileEnd
    * @memberof module:nsolid
    */
@@ -138,7 +138,7 @@ module.exports = ({ heapProfile: _heapProfile,
    * } catch (err) {
    *   // In case an error happens
    * }
-   * @throws Will throw an error if an error happens and no callback was passed.
+   * @throws {Error} Will throw an error if an error happens and no callback was passed.
    * @function profile
    * @memberof module:nsolid
    */
@@ -193,7 +193,7 @@ module.exports = ({ heapProfile: _heapProfile,
    *     }, 1000);
    *   }
    * });
-   * @throws Will throw an error if an error happens and no callback was passed.
+   * @throws {Error} Will throw an error if an error happens and no callback was passed.
    * @function heapProfileEnd
    * @memberof module:nsolid
    */
@@ -243,7 +243,7 @@ module.exports = ({ heapProfile: _heapProfile,
    * } catch (err) {
    *   // In case an error happens
    * }
-   * @throws Will throw an error if an error happens and no callback was passed.
+   * @throws {Error} Will throw an error if an error happens and no callback was passed.
    * @function heapSampling
    * @memberof module:nsolid
    */
@@ -302,7 +302,7 @@ module.exports = ({ heapProfile: _heapProfile,
    *     }, 1000);
    *   }
    * });
-   * @throws Will throw an error if an error happens and no callback was passed.
+   * @throws {Error} Will throw an error if an error happens and no callback was passed.
    * @function heapSamplingEnd
    * @memberof module:nsolid
    */
@@ -344,7 +344,7 @@ module.exports = ({ heapProfile: _heapProfile,
    * } catch (err) {
    *   // In case an error happens
    * }
-   * @throws Will throw an error if an error happens and no callback was passed.
+   * @throws {Error} Will throw an error if an error happens and no callback was passed.
    * @function snapshot
    * @memberof module:nsolid
    */

lib/nsolid.js

@@ -663,7 +663,7 @@ function resumeMetrics() {
  * started it updates its configuration.
  * @param {NSolidConfig} config
  * @returns {module:nsolid} the NSolid object.
- * @throws exception if the configuration is bogus.
+ * @throws {Error} exception if the configuration is bogus.
  * @alias module:nsolid.start
  */
 function start(config/* , agentCb */) {

test/addons/nsolid-custom-command/nsolid-custom-command.js

@@ -216,7 +216,7 @@ function runTest({ args, listener, command, ret, err, status }, done) {
         return done();
       }
 
-      assert.ok(false);
+      assert.fail('Expected callback to receive a result or error');
     })), 0);
 
   assert.strictEqual(binding.customCommand(requestId,

test/addons/nsolid-metrics-stream/nsolid-metrics-stream.js

@@ -95,7 +95,7 @@ function test() {
           else if (type === KHttpServer)
             counters.http_server++;
           else
-            assert(0);
+            assert.fail(`Unexpected metric type: ${type}`);
         });
 
         assert.strictEqual(counters.dns, 20);

test/addons/nsolid-tracing/test-http-agent-close.js

@@ -2,14 +2,14 @@
 'use strict';
 const common = require('../../common');
 const { checkTracesOnExit } = require('../../common/nsolid-traces');
-const { fixturesDir } = require('../../common/fixtures');
+const fixtures = require('../../common/fixtures');
 const { setupNSolid } = require('./utils');
 const assert = require('assert');
 const http = require('http');
 const bindingPath = require.resolve(`./build/${common.buildType}/binding`);
 const binding = require(bindingPath);
 const api = require(require.resolve('@opentelemetry/api',
-                                    { paths: [fixturesDir] }));
+                                    { paths: [fixtures.fixturesDir] }));
 
 const expectedTraces = [
   {

test/addons/nsolid-tracing/test-otel-basic.js

@@ -7,13 +7,13 @@ const common = require('../../common');
 const assert = require('assert');
 const { checkTracesOnExit } = require('../../common/nsolid-traces');
 const { setupNSolid } = require('./utils');
-const { fixturesDir } = require('../../common/fixtures');
+const fixtures = require('../../common/fixtures');
 const bindingPath = require.resolve(`./build/${common.buildType}/binding`);
 const binding = require(bindingPath);
 
 const nsolid = require('nsolid');
 const api = require(require.resolve('@opentelemetry/api',
-                                    { paths: [fixturesDir] }));
+                                    { paths: [fixtures.fixturesDir] }));
 
 const expectedTraces = [
   {

test/addons/nsolid-tracing/test-otel-basic2.js

@@ -11,13 +11,13 @@
 const common = require('../../common');
 const { checkTracesOnExit } = require('../../common/nsolid-traces');
 const { setupNSolid } = require('./utils');
-const { fixturesDir } = require('../../common/fixtures');
+const fixtures = require('../../common/fixtures');
 const bindingPath = require.resolve(`./build/${common.buildType}/binding`);
 const binding = require(bindingPath);
 
 const nsolid = require('nsolid');
 const api = require(require.resolve('@opentelemetry/api',
-                                    { paths: [fixturesDir] }));
+                                    { paths: [fixtures.fixturesDir] }));
 
 const expectedTraces = [
   {

test/addons/nsolid-tracing/test-otel-context-bind-ee.js

@@ -15,13 +15,13 @@ const assert = require('assert');
 const EventEmitter = require('events');
 const { checkTracesOnExit } = require('../../common/nsolid-traces');
 const { setupNSolid } = require('./utils');
-const { fixturesDir } = require('../../common/fixtures');
+const fixtures = require('../../common/fixtures');
 const bindingPath = require.resolve(`./build/${common.buildType}/binding`);
 const binding = require(bindingPath);
 
 const nsolid = require('nsolid');
 const api = require(require.resolve('@opentelemetry/api',
-                                    { paths: [fixturesDir] }));
+                                    { paths: [fixtures.fixturesDir] }));
 
 const expectedTraces = [
   {

test/addons/nsolid-tracing/test-otel-context-bind-fn.js

@@ -14,13 +14,13 @@ const common = require('../../common');
 const assert = require('assert');
 const { checkTracesOnExit } = require('../../common/nsolid-traces');
 const { setupNSolid } = require('./utils');
-const { fixturesDir } = require('../../common/fixtures');
+const fixtures = require('../../common/fixtures');
 const bindingPath = require.resolve(`./build/${common.buildType}/binding`);
 const binding = require(bindingPath);
 
 const nsolid = require('nsolid');
 const api = require(require.resolve('@opentelemetry/api',
-                                    { paths: [fixturesDir] }));
+                                    { paths: [fixtures.fixturesDir] }));
 
 const expectedTraces = [
   {

test/addons/nsolid-tracing/test-otel-context-enable-disable.js

@@ -15,13 +15,13 @@ const common = require('../../common');
 const assert = require('assert');
 const { checkTracesOnExit } = require('../../common/nsolid-traces');
 const { setupNSolid } = require('./utils');
-const { fixturesDir } = require('../../common/fixtures');
+const fixtures = require('../../common/fixtures');
 const bindingPath = require.resolve(`./build/${common.buildType}/binding`);
 const binding = require(bindingPath);
 
 const nsolid = require('nsolid');
 const api = require(require.resolve('@opentelemetry/api',
-                                    { paths: [fixturesDir] }));
+                                    { paths: [fixtures.fixturesDir] }));
 
 const expectedTraces = [
   {