lib: add metrics support for http2

Author: santigimeno

lib/internal/nsolid_diag.js

@@ -23,6 +23,8 @@ const dc = require('diagnostics_channel');
 const {
   kHttpClientAbortCount,
   kHttpClientCount,
+  kHttpServerAbortCount,
+  kHttpServerCount,
   kSpanHttpClient,
   kSpanHttpMethod,
   kSpanHttpReqUrl,
@@ -31,6 +33,9 @@ const {
 
 const undiciFetch = dc.tracingChannel('undici:fetch');
 
+// To lazy load the http2 constants
+let http2Constants;
+
 let tracingEnabled = false;
 
 const fetchSubscribeListener = (message, name) => {};
@@ -119,3 +124,47 @@ dc.subscribe('undici:request:error', ({ request, error }) => {
     }
   }
 });
+
+dc.subscribe('http2.client.stream.created', ({ stream }) => {
+  stream[nsolid_tracer_s] = {
+    start: now(),
+    response: false,
+  };
+});
+
+dc.subscribe('http2.client.stream.finish', ({ stream, flags }) => {
+  stream[nsolid_tracer_s].response = true;
+});
+
+dc.subscribe('http2.client.stream.close', ({ stream, code }) => {
+  http2Constants ||= require('internal/http2/core').constants;
+  const tracingInfo = stream[nsolid_tracer_s];
+  if (code === http2Constants.NGHTTP2_NO_ERROR && tracingInfo.response) {
+    nsolid_counts[kHttpClientCount]++;
+    nsolidApi.pushClientBucket(now() - tracingInfo.start);
+  } else {
+    nsolid_counts[kHttpClientAbortCount]++;
+  }
+});
+
+dc.subscribe('http2.server.stream.start', ({ stream }) => {
+  stream[nsolid_tracer_s] = {
+    start: now(),
+    response: false,
+  };
+});
+
+dc.subscribe('http2.server.stream.finish', ({ stream, flags }) => {
+  stream[nsolid_tracer_s].response = true;
+});
+
+dc.subscribe('http2.server.stream.close', ({ stream, code }) => {
+  http2Constants ||= require('internal/http2/core').constants;
+  const tracingInfo = stream[nsolid_tracer_s];
+  if (code === http2Constants.NGHTTP2_NO_ERROR && tracingInfo.response) {
+    nsolid_counts[kHttpServerCount]++;
+    nsolidApi.pushServerBucket(now() - tracingInfo.start);
+  } else {
+    nsolid_counts[kHttpServerAbortCount]++;
+  }
+});

test/parallel/test-diagnostics-channel-http2.js

@@ -20,6 +20,10 @@ const isServerHttp2Stream = (stream) => {
          stream.session.type === http2.constants.NGHTTP2_SESSION_SERVER;
 };
 
+const isHttp2Stream = (stream) => {
+  return stream instanceof Http2Stream;
+};
+
 const isError = (error) => error instanceof Error;
 
 const isValidHeaders = (headers) => {
@@ -37,7 +41,7 @@ dc.subscribe('http2.client.stream.start', common.mustCall(({ stream, headers })
 }, 2));
 
 dc.subscribe('http2.client.stream.error', common.mustCall(({ stream, error }) => {
-  assert.strictEqual(isClientHttp2Stream(stream), true);
+  assert.strictEqual(isHttp2Stream(stream), true);
   assert.strictEqual(isError(error), true);
 }));
 
@@ -57,7 +61,7 @@ dc.subscribe('http2.server.stream.start', common.mustCall(({ stream, headers })
 }, 2));
 
 dc.subscribe('http2.server.stream.error', common.mustCall(({ stream, error }) => {
-  assert.strictEqual(isServerHttp2Stream(stream), true);
+  assert.strictEqual(isHttp2Stream(stream), true);
   assert.strictEqual(isError(error), true);
 }));