Move feature modules to shared and tighten lint rules

Refactor shared code: moved several commonly-used hooks, stores, libs, and UI components from features/* into shared/* to centralize reuse (e.g. use-note-mutations, use-note-queries, note-list-navigation (+tests), use-ui-store, bootstrap-error, conflict-resolution-dialog, delete-publish-dialog). Updated imports across the app to reference the new shared paths (editor, notes-pane, shell, sidebar, settings, etc.). Also tightened linting by changing no-restricted-imports severity from "warn" to "error" in .oxlintrc.json for the feature-specific overrides.

Author: ChristianChiarulli

app/.oxlintrc.json

@@ -1,6 +1,10 @@
 {
   "$schema": "./node_modules/oxlint/configuration_schema.json",
   "plugins": ["typescript", "react", "unicorn", "import"],
+  "jsPlugins": ["eslint-plugin-boundaries"],
+  "env": {
+    "builtin": true
+  },
   "categories": {
     "correctness": "error",
     "suspicious": "error",
@@ -10,6 +14,23 @@
   "options": {
     "typeAware": true
   },
+  "settings": {
+    "import/resolver": {
+      "typescript": true,
+      "node": true
+    },
+    "boundaries/elements": [
+      { "type": "app-root", "pattern": "src/app.tsx", "mode": "file" },
+      { "type": "app-root", "pattern": "src/main.tsx", "mode": "file" },
+      { "type": "app-root", "pattern": "src/features/shell" },
+      {
+        "type": "feature",
+        "pattern": "src/features/*",
+        "capture": ["featureName"]
+      },
+      { "type": "shared", "pattern": "src/shared" }
+    ]
+  },
   "rules": {
     "typescript/no-floating-promises": [
       "error",
@@ -62,13 +83,31 @@
     "no-nested-ternary": "off",
     "unicorn/prefer-add-event-listener": "off",
     "typescript/no-unnecessary-type-conversion": "off",
-    "no-restricted-imports": [
-      "warn",
+    "boundaries/dependencies": [
+      "error",
       {
-        "patterns": [
+        "default": "disallow",
+        "rules": [
+          {
+            "from": { "type": "app-root" },
+            "allow": { "to": { "type": "*" } }
+          },
           {
-            "group": ["@/features/*/*/**"],
-            "message": "Cross-feature deep imports break feature boundaries. Import from the feature barrel (@/features/<feature>) instead."
+            "from": { "type": "shared" },
+            "allow": { "to": { "type": "shared" } }
+          },
+          {
+            "from": { "type": "feature" },
+            "allow": {
+              "to": [
+                {
+                  "type": "feature",
+                  "captured": { "featureName": "{{ featureName }}" }
+                },
+                { "type": "shared" },
+                { "type": "app-root" }
+              ]
+            }
           }
         ]
       }
@@ -81,153 +120,5 @@
     "src-tauri/**",
     "scripts/**"
   ],
-  "overrides": [
-    {
-      "files": ["src/features/command-palette/**"],
-      "rules": {
-        "no-restricted-imports": [
-          "warn",
-          {
-            "patterns": [
-              {
-                "group": [
-                  "@/features/*/*/**",
-                  "!@/features/command-palette/**"
-                ],
-                "message": "Cross-feature deep imports break feature boundaries. Import from the feature barrel (@/features/<feature>) instead."
-              }
-            ]
-          }
-        ]
-      }
-    },
-    {
-      "files": ["src/features/editor/**"],
-      "rules": {
-        "no-restricted-imports": [
-          "warn",
-          {
-            "patterns": [
-              {
-                "group": ["@/features/*/*/**", "!@/features/editor/**"],
-                "message": "Cross-feature deep imports break feature boundaries. Import from the feature barrel (@/features/<feature>) instead."
-              }
-            ]
-          }
-        ]
-      }
-    },
-    {
-      "files": ["src/features/editor-pane/**"],
-      "rules": {
-        "no-restricted-imports": [
-          "warn",
-          {
-            "patterns": [
-              {
-                "group": ["@/features/*/*/**", "!@/features/editor-pane/**"],
-                "message": "Cross-feature deep imports break feature boundaries. Import from the feature barrel (@/features/<feature>) instead."
-              }
-            ]
-          }
-        ]
-      }
-    },
-    {
-      "files": ["src/features/notes-pane/**"],
-      "rules": {
-        "no-restricted-imports": [
-          "warn",
-          {
-            "patterns": [
-              {
-                "group": ["@/features/*/*/**", "!@/features/notes-pane/**"],
-                "message": "Cross-feature deep imports break feature boundaries. Import from the feature barrel (@/features/<feature>) instead."
-              }
-            ]
-          }
-        ]
-      }
-    },
-    {
-      "files": ["src/features/publishing/**"],
-      "rules": {
-        "no-restricted-imports": [
-          "warn",
-          {
-            "patterns": [
-              {
-                "group": ["@/features/*/*/**", "!@/features/publishing/**"],
-                "message": "Cross-feature deep imports break feature boundaries. Import from the feature barrel (@/features/<feature>) instead."
-              }
-            ]
-          }
-        ]
-      }
-    },
-    {
-      "files": ["src/features/settings/**"],
-      "rules": {
-        "no-restricted-imports": [
-          "warn",
-          {
-            "patterns": [
-              {
-                "group": ["@/features/*/*/**", "!@/features/settings/**"],
-                "message": "Cross-feature deep imports break feature boundaries. Import from the feature barrel (@/features/<feature>) instead."
-              }
-            ]
-          }
-        ]
-      }
-    },
-    {
-      "files": ["src/features/shell/**"],
-      "rules": {
-        "no-restricted-imports": [
-          "warn",
-          {
-            "patterns": [
-              {
-                "group": ["@/features/*/*/**", "!@/features/shell/**"],
-                "message": "Cross-feature deep imports break feature boundaries. Import from the feature barrel (@/features/<feature>) instead."
-              }
-            ]
-          }
-        ]
-      }
-    },
-    {
-      "files": ["src/features/sidebar-pane/**"],
-      "rules": {
-        "no-restricted-imports": [
-          "warn",
-          {
-            "patterns": [
-              {
-                "group": ["@/features/*/*/**", "!@/features/sidebar-pane/**"],
-                "message": "Cross-feature deep imports break feature boundaries. Import from the feature barrel (@/features/<feature>) instead."
-              }
-            ]
-          }
-        ]
-      }
-    },
-    {
-      "files": ["src/features/sync/**"],
-      "rules": {
-        "no-restricted-imports": [
-          "warn",
-          {
-            "patterns": [
-              {
-                "group": ["@/features/*/*/**", "!@/features/sync/**"],
-                "message": "Cross-feature deep imports break feature boundaries. Import from the feature barrel (@/features/<feature>) instead."
-              }
-            ]
-          }
-        ]
-      }
-    }
-  ]
+  "overrides": []
 }

app/package.json

@@ -71,6 +71,8 @@
     "@vitest/coverage-v8": "^4.1.4",
     "babel-plugin-react-compiler": "^1.0.0",
     "culori": "^4.0.2",
+    "eslint-import-resolver-typescript": "^4.4.4",
+    "eslint-plugin-boundaries": "^6.0.2",
     "jsdom": "^29.0.2",
     "oxfmt": "^0.44.0",
     "oxlint": "^1.59.0",

app/src/app.tsx

@@ -7,10 +7,10 @@ import { Toaster } from "@/shared/ui/sonner";
 import { AccountSwitcherDialog } from "@/features/settings/account-switcher-dialog";
 import { SettingsDialog } from "@/features/settings/settings-dialog";
 import { CommandPalette } from "@/features/command-palette";
-import { BootstrapError } from "@/features/shell/ui/bootstrap-error";
-import { ConflictResolutionDialog } from "@/features/shell/ui/conflict-resolution-dialog";
-import { DeletePublishDialog } from "@/features/shell/ui/delete-publish-dialog";
-import { EditorPane } from "@/features/editor-pane";
+import { BootstrapError } from "@/shared/ui/bootstrap-error";
+import { ConflictResolutionDialog } from "@/shared/ui/conflict-resolution-dialog";
+import { DeletePublishDialog } from "@/shared/ui/delete-publish-dialog";
+import { EditorPane } from "@/features/editor/ui/editor-pane";
 import { NoteHistoryDialog } from "@/features/shell/note-history-dialog";
 import { NotesPane } from "@/features/notes-pane";
 import { PublishDialog, PublishShortNoteDialog } from "@/features/publishing";
@@ -21,7 +21,7 @@ import { useShellController } from "@/features/shell/use-shell-controller";
 import {
   useNotesPanelVisible,
   useSidebarVisible,
-} from "@/features/settings/store/use-ui-store";
+} from "@/shared/stores/use-ui-store";
 
 const IS_MACOS = navigator.userAgent.includes("Mac");
 

app/src/features/editor-pane/index.ts

@@ -80,7 +80,7 @@ import {
 } from "@/features/editor/lib/note-editor-selection";
 import { useNoteEditorSearchSync } from "@/features/editor/hooks/use-note-editor-search-sync";
 import { useNoteEditorToolbarActions } from "@/features/editor/hooks/use-note-editor-toolbar-actions";
-import { uiStore } from "@/features/settings/store/use-ui-store";
+import { uiStore } from "@/shared/stores/use-ui-store";
 import { useShellNavigationStore } from "@/shared/stores/use-shell-navigation-store";
 import {
   isEditorFindShortcut,

…r-pane/hooks/use-editor-scroll-header.ts …editor/hooks/use-editor-scroll-header.tsapp/src/features/editor-pane/hooks/use-editor-scroll-header.ts renamed to app/src/features/editor/hooks/use-editor-scroll-header.ts app/src/features/editor-pane/hooks/use-editor-scroll-header.ts renamed to app/src/features/editor/hooks/use-editor-scroll-header.ts

@@ -2,7 +2,7 @@ import { ChevronLeft, ChevronRight } from "lucide-react";
 
 import { Button } from "@/shared/ui/button";
 import { type NoteConflictInfo } from "@/shared/api/types";
-import { formatConflictHeadTimestamp } from "@/features/editor-pane/lib/editor-pane-utils";
+import { formatConflictHeadTimestamp } from "@/features/editor/lib/editor-pane-utils";
 
 type ViewableSnapshot = NoteConflictInfo["snapshots"][number];