cleanup

Author: jialinli98

ethereum/oracles/src/noir/circuit/vk.ts

@@ -13,22 +13,20 @@ async function convertVkBinaryToFields(vkDirPath: string, vkAsFieldsPath: string
   const vkPath = path.join(vkDirPath, 'vk');
   const vkHashPath = path.join(vkDirPath, 'vk_hash');
 
-  // Read binary files
   const vkBinary = await readFile(vkPath);
   const vkHashBinary = await readFile(vkHashPath);
 
-  // Use official bb.js API to convert VK to fields
+  // convert VK to fields
   const api = await BarretenbergAPI.new({ threads: 1 });
   try {
     const result = await api.vkAsFields({ verificationKey: vkBinary });
 
-    // Convert Fr objects (Uint8Array) to hex strings
+    // Convert Fr objects to hex strings
     const vkAsFields = result.fields.map((field) => '0x' + Buffer.from(field).toString('hex'));
 
-    // Convert hash to hex string
     const vkHash = '0x' + vkHashBinary.toString('hex');
 
-    // Write as JSON: [vkHash, ...vkAsFields]
+    // write as JSON
     await writeObject([vkHash, ...vkAsFields], vkAsFieldsPath);
   } finally {
     await api.destroy();
@@ -46,30 +44,23 @@ export async function generateVk(
     let artifact: CompiledCircuit;
 
     if (typeof bytecodeOrArtifact === 'string') {
-      // Legacy: just bytecode string - create minimal artifact
-      // bb expects circuit JSON (not raw bytecode) when file has .json extension
+      // bb expects circuit JSON when file has .json extension
       artifact = {
         noir_version: '1.0.0',
         hash: 0,
         abi: { parameters: [], return_type: null, error_types: {} },
-        bytecode: bytecodeOrArtifact, // Keep compressed - bb handles decompression
+        bytecode: bytecodeOrArtifact
       } as any;
     } else {
-      // New: full artifact - use as-is
-      // bb expects bytecode to remain compressed (gzipped + base64)
       artifact = bytecodeOrArtifact;
     }
 
-    // Write circuit JSON to temp file
-    // bb reads .json files as JSON format and decompresses bytecode internally
     await writeFile(acirPath, JSON.stringify(artifact));
 
     const barretenberg = await Barretenberg.create();
-    // write_vk creates a directory with 'vk' and 'vk_hash' files
     await barretenberg.writeVK(acirPath, vkPath);
 
     // Convert binary VK files to field representation
-    // vk_as_fields CLI command was removed in newer bb, so we do it in TypeScript
     await convertVkBinaryToFields(vkPath, vkAsFieldsPath);
   });
 }