fix mod position

Author: jialinli98

.github/workflows/benchmark.yml

@@ -33,13 +33,6 @@ jobs:
         env:
           BACKEND: /home/runner/.bb/bb
 
-      - name: Compare gates reports
-        id: gates_diff
-        uses: noir-lang/noir-gates-diff@dbe920a8dcc3370af4be4f702ca9cef29317bec1
-        with:
-          report: gates_report.json
-          summaryQuantile: 0.9 # only display the 10% most significant circuit size diffs in the summary (defaults to 20%)
-      
       - name: Store ACIR opcode benchmark result
         uses: benchmark-action/github-action-benchmark@v1
         with:
@@ -91,16 +84,6 @@ jobs:
       - name: Generate brillig report
         run: ./scripts/build-brillig-report.sh
 
-      - name: Compare brillig reports
-        id: brillig_bytecode_diff
-        uses: noir-lang/noir-gates-diff@dbe920a8dcc3370af4be4f702ca9cef29317bec1
-        with:
-          report: brillig_report.json
-          header: |
-            # Changes to Brillig bytecode sizes
-          brillig_report: true
-          summaryQuantile: 0.9 # only display the 10% most significant circuit size diffs in the summary (defaults to 20%)
-
       - name: Store brillig benchmark result
         uses: benchmark-action/github-action-benchmark@v1
         with:

scripts/build-gates-report.sh

@@ -5,6 +5,7 @@ comptime fn make_bench(m: Module, params: Quoted) -> Quoted {
     let add_bench_name = f"add_{module_name}".quoted_contents();
     let sub_bench_name = f"sub_{module_name}".quoted_contents();
     let one_bench_name = f"one_{module_name}".quoted_contents();
+    let mul_bench_name = f"mul_{module_name}".quoted_contents();
     let BigCurve = quote { crate::BigCurve };
 
     let from_field_bench_name = f"from_field_{module_name}".quoted_contents();
@@ -13,17 +14,17 @@ comptime fn make_bench(m: Module, params: Quoted) -> Quoted {
     quote {
         #[export]
         fn $add_bench_name(a: $typ, b: $typ) -> $typ {
-            a.add(b)
+            a + b
         }
 
         #[export] 
         fn $sub_bench_name(a: $typ, b: $typ) -> $typ {
-            a.sub(b)
+            a-b
         }
 
         #[export]
         fn $one_bench_name() -> $typ {
-            $typ::one()
+            $BigCurve::one()
         }
 
     }

src/benchmarks/bigcurve_benchmarks.nr

@@ -3,7 +3,6 @@ pub(crate) mod curve_jac;
 mod test_data;
 mod bigcurve_test;
 pub mod scalar_field;
-mod benchmarks;
 pub(crate) mod utils;
 pub(crate) mod curves;
 
@@ -13,6 +12,7 @@ use bignum::bignum::evaluate_quadratic_expression;
 use crate::curve_jac::AffineTranscript;
 use crate::scalar_field::ScalarField;
 use std::ops::{Add, Neg, Sub};
+mod benchmarks;
 
 /// Implements an elliptic curve over a prime field that is not the circuit's native field.