Skip to content

Commit a1fe0ee

Browse files
authored
chore: bump version of nargo to use in CI (#96)
1 parent c13415f commit a1fe0ee

File tree

3 files changed

+28
-25
lines changed

3 files changed

+28
-25
lines changed

.github/workflows/benchmark.yml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,19 +10,22 @@ jobs:
1010
test:
1111
name: Benchmark library
1212
runs-on: ubuntu-latest
13+
permissions:
14+
contents: write
15+
pull-requests: write
1316
steps:
1417
- name: Checkout sources
1518
uses: actions/checkout@v4
1619

1720
- name: Install Nargo
1821
uses: noir-lang/[email protected]
1922
with:
20-
toolchain: nightly-2025-08-15
23+
toolchain: 1.0.0-beta.12
2124

2225
- name: Install bb
2326
run: |
2427
curl -L https://bbup.aztec.network | bash
25-
~/.bb/bbup -nv 1.0.0-beta.9
28+
~/.bb/bbup -nv 1.0.0-beta.12
2629
sudo apt install libc++-dev
2730
2831
- name: Build Noir benchmark programs

.github/workflows/test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ on:
88

99
env:
1010
CARGO_TERM_COLOR: always
11-
MINIMUM_NOIR_VERSION: nightly-2025-08-15
11+
MINIMUM_NOIR_VERSION: v1.0.0-beta.12
1212

1313
jobs:
1414
noir-version-list:

src/curve_jac.nr

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -669,15 +669,15 @@ where
669669
) -> (Self, [AffineTranscript<B>; NScalarSlices * Size + NScalarSlices * 4 + Size * 9 - 3]) {
670670
let mut (accumulator, transcript)
671671
: (Self, [JTranscript<B>; NScalarSlices * Size + NScalarSlices * 4 + Size * 9 - 3]) =
672-
CurveJ::msm_partial(points, scalars);
673-
let op = accumulator.sub(CurveJ::offset_generator_final());
674-
transcript[73 * Size + 252] = op.1;
675-
accumulator = op.0;
676-
let affine_transcript: [AffineTranscript<B>; NScalarSlices * Size + NScalarSlices * 4 + Size * 9 - 3] =
677-
AffineTranscript::from_jacobian_transcript(transcript);
672+
CurveJ::msm_partial(points, scalars);
673+
let op = accumulator.sub(CurveJ::offset_generator_final());
674+
transcript[73 * Size + 252] = op.1;
675+
accumulator = op.0;
676+
let affine_transcript: [AffineTranscript<B>; NScalarSlices * Size + NScalarSlices * 4 + Size * 9 - 3] =
677+
AffineTranscript::from_jacobian_transcript(transcript);
678678

679-
(accumulator, affine_transcript)
680-
}
679+
(accumulator, affine_transcript)
680+
}
681681

682682
pub(crate) unconstrained fn compute_linear_expression_transcript<let NScalarSlices: u32, let NMuls: u32, let NAdds: u32>(
683683
mut mul_points: [Curve; NMuls],
@@ -695,21 +695,21 @@ where
695695

696696
let mut (accumulator, transcript)
697697
: (Self, [JTranscript<B>; NScalarSlices * NMuls + NScalarSlices * 4 + NMuls * 9 + NAdds - 3]) =
698-
CurveJ::msm_partial(mul_j, scalars);
699-
let mut transcript_ptr: u32 = NScalarSlices * NMuls + NScalarSlices * 4 + NMuls * 9 - 4;
700-
for i in 0..NAdds {
701-
let op = accumulator.conditional_incomplete_add(add_j[i], !add_j[i].is_infinity);
702-
transcript[transcript_ptr] = op.1;
703-
accumulator = op.0;
704-
transcript_ptr += 1;
705-
}
706-
707-
let op = accumulator.sub(CurveJ::offset_generator_final());
698+
CurveJ::msm_partial(mul_j, scalars);
699+
let mut transcript_ptr: u32 = NScalarSlices * NMuls + NScalarSlices * 4 + NMuls * 9 - 4;
700+
for i in 0..NAdds {
701+
let op = accumulator.conditional_incomplete_add(add_j[i], !add_j[i].is_infinity);
708702
transcript[transcript_ptr] = op.1;
709703
accumulator = op.0;
710-
let affine_transcript: [AffineTranscript<B>; NScalarSlices * NMuls + NScalarSlices * 4 + NMuls * 9 + NAdds - 3] =
711-
AffineTranscript::from_jacobian_transcript(transcript);
712-
713-
(accumulator, affine_transcript)
704+
transcript_ptr += 1;
714705
}
706+
707+
let op = accumulator.sub(CurveJ::offset_generator_final());
708+
transcript[transcript_ptr] = op.1;
709+
accumulator = op.0;
710+
let affine_transcript: [AffineTranscript<B>; NScalarSlices * NMuls + NScalarSlices * 4 + NMuls * 9 + NAdds - 3] =
711+
AffineTranscript::from_jacobian_transcript(transcript);
712+
713+
(accumulator, affine_transcript)
714+
}
715715
}

0 commit comments

Comments
 (0)