fix mod position

Author: jialinli98

.github/workflows/benchmark.yml

@@ -33,13 +33,6 @@ jobs:
         env:
           BACKEND: /home/runner/.bb/bb
 
-      - name: Compare gates reports
-        id: gates_diff
-        uses: noir-lang/noir-gates-diff@dbe920a8dcc3370af4be4f702ca9cef29317bec1
-        with:
-          report: gates_report.json
-          summaryQuantile: 0.9 # only display the 10% most significant circuit size diffs in the summary (defaults to 20%)
-      
       - name: Store ACIR opcode benchmark result
         uses: benchmark-action/github-action-benchmark@v1
         with:
@@ -91,16 +84,6 @@ jobs:
       - name: Generate brillig report
         run: ./scripts/build-brillig-report.sh
 
-      - name: Compare brillig reports
-        id: brillig_bytecode_diff
-        uses: noir-lang/noir-gates-diff@dbe920a8dcc3370af4be4f702ca9cef29317bec1
-        with:
-          report: brillig_report.json
-          header: |
-            # Changes to Brillig bytecode sizes
-          brillig_report: true
-          summaryQuantile: 0.9 # only display the 10% most significant circuit size diffs in the summary (defaults to 20%)
-
       - name: Store brillig benchmark result
         uses: benchmark-action/github-action-benchmark@v1
         with:

README.md

@@ -29,7 +29,6 @@ The most efficient method to evaluate curve operations is `BigCurve::evaluate_li
 - Add method to check point is in prime-order subgroup for curves with a cofactor
 - Parametrise and test with a degree-2 extension field instead of `BigNum`
 - [x] Add curve parameters for commonly used curves (BN254, BLS12-381, MNT4, MNT6, Pasta, Vella, Secp256K1, Secp256R1)
-- Create benchmarks
 - Add support for curve endomorphisms where applicable (if base field and scalar field both contain cube roots of unity, we can reduce the number of point doublings required for an MSM in half)
 
 # FAQ

scripts/build-gates-report.sh

@@ -1,29 +1,73 @@
-use crate::curves::bn254::{BN254};
-use crate::curves::secp256k1::{Secp256k1};
+use crate::curves::bls12_377::BLS12_377;
+use crate::curves::bls12_381::BLS12_381;
+use crate::curves::bn254::BN254;
+use crate::curves::mnt4_753::MNT4_753;
+use crate::curves::mnt6_753::MNT6_753;
+use crate::curves::pallas::Pallas;
+use crate::curves::secp256k1::Secp256k1;
+use crate::curves::secp256r1::Secp256r1;
+use crate::curves::secp384r1::Secp384r1;
+use crate::curves::vesta::Vesta;
 comptime fn make_bench(m: Module, params: Quoted) -> Quoted {
     let module_name = m.name();
     let add_bench_name = f"add_{module_name}".quoted_contents();
     let sub_bench_name = f"sub_{module_name}".quoted_contents();
+    let neg_bench_name = f"neg_{module_name}".quoted_contents();
     let one_bench_name = f"one_{module_name}".quoted_contents();
+    let mul_bench_name = f"mul_{module_name}".quoted_contents();
+    let eq_bench_name = f"eq_{module_name}".quoted_contents();
+    let validate_on_curve_bench_name = f"validate_on_curve_{module_name}".quoted_contents();
+    let evaluate_linear_expression_bench_name =
+        f"evaluate_linear_expression_{module_name}".quoted_contents();
+    let hash_to_curve_bench_name = f"hash_to_curve_{module_name}".quoted_contents();
     let BigCurve = quote { crate::BigCurve };
+    let ScalarField = quote { crate::ScalarField };
 
-    let from_field_bench_name = f"from_field_{module_name}".quoted_contents();
     let typ = params.as_type();
 
     quote {
         #[export]
         fn $add_bench_name(a: $typ, b: $typ) -> $typ {
-            a.add(b)
+            a + b
         }
 
         #[export] 
         fn $sub_bench_name(a: $typ, b: $typ) -> $typ {
-            a.sub(b)
+            a-b
+        }
+
+        #[export]
+        fn $neg_bench_name(a: $typ) -> $typ {
+            -a
+        }
+
+        #[export]
+        fn $eq_bench_name(a: $typ, b: $typ) -> bool {
+            a==b
+        }
+        #[export]
+        fn $validate_on_curve_bench_name(a: $typ) {
+            $BigCurve::validate_on_curve(a);
+        }
+
+        #[export]
+        fn $mul_bench_name(a: $typ, b: $ScalarField<64>) -> $typ {
+            $BigCurve::mul(a, b)
         }
 
         #[export]
         fn $one_bench_name() -> $typ {
-            $typ::one()
+            $BigCurve::one()
+        }
+
+        #[export]
+        fn $hash_to_curve_bench_name(a: [u8; 10]) -> $typ {
+            $BigCurve::hash_to_curve(a)
+        }
+
+        #[export]
+        fn $evaluate_linear_expression_bench_name(a: [$typ; 3], b: [$ScalarField<64>; 3], c: [$typ; 2]) -> $typ {
+            $BigCurve::evaluate_linear_expression(a, b, c)
         }
 
     }
@@ -32,5 +76,29 @@ comptime fn make_bench(m: Module, params: Quoted) -> Quoted {
 #[make_bench(quote { BN254 })]
 mod BN254_Bench {}
 
+#[make_bench(quote { BLS12_381 })]
+mod BLS12_381_Bench {}
+
+#[make_bench(quote { BLS12_377 })]
+mod BLS12_377_Bench {}
+
+#[make_bench(quote { MNT4_753 })]
+mod MNT4_753_Bench {}
+
+#[make_bench(quote { MNT6_753 })]
+mod MNT6_753_Bench {}
+
+#[make_bench(quote { Pallas })]
+mod Pallas_Bench {}
+
 #[make_bench(quote { Secp256k1 })]
-mod Secp256k1_Bench {}
+mod Secp256k1_Bench {}
+
+#[make_bench(quote { Secp256r1 })]
+mod Secp256r1_Bench {}
+
+#[make_bench(quote { Secp384r1 })]
+mod Secp384r1_Bench {}
+
+#[make_bench(quote { Vesta })]
+mod Vesta_Bench {}

src/benchmarks/bigcurve_benchmarks.nr

@@ -1 +1 @@
-mod bigcurve_benchmarks;
+mod bigcurve_benchmarks;

src/benchmarks/mod.nr

@@ -1,9 +1,7 @@
-
 pub(crate) mod curve_jac;
 mod test_data;
 mod bigcurve_test;
 pub mod scalar_field;
-mod benchmarks;
 pub(crate) mod utils;
 pub(crate) mod curves;
 
@@ -13,6 +11,7 @@ use bignum::bignum::evaluate_quadratic_expression;
 use crate::curve_jac::AffineTranscript;
 use crate::scalar_field::ScalarField;
 use std::ops::{Add, Neg, Sub};
+mod benchmarks;
 
 /// Implements an elliptic curve over a prime field that is not the circuit's native field.
 

src/lib.nr

@@ -102,7 +102,7 @@ where
 #[test]
 fn test_compute_and_print_offset_generators() {
     unsafe {
-        let _ = <BN254 as BigCurve<BN254_Fq>>::one();
+        let _ = BN254::one();
         compute_and_print_offset_generators::<BN254_Fq, _, _, 64, BN254>("BN254_Fq", "BN254", 1);
         // compute_and_print_offset_generators::<PallasBN, _, _, 64>("Pallas_Fq", "Pallas", 1);
         // compute_and_print_offset_generators::<VestaBN, _, _, 64>("Vesta_Fq", "Vesta", 1);