Fixed setup_torch_device to only enable MPS for ARM based macs as pytorch doesn't really support MPS on non-apple silicon

Author: beveradb

audio_separator/separator/separator.py

@@ -158,12 +158,12 @@ def setup_accelerated_inferencing_device(self):
         """
         This method sets up the PyTorch and/or ONNX Runtime inferencing device, using GPU hardware acceleration if available.
         """
-        self.log_system_info()
+        system_info = self.get_system_info()
         self.check_ffmpeg_installed()
         self.log_onnxruntime_packages()
-        self.setup_torch_device()
+        self.setup_torch_device(system_info)
 
-    def log_system_info(self):
+    def get_system_info(self):
         """
         This method logs the system information, including the operating system, CPU archutecture and Python version
         """
@@ -179,6 +179,7 @@ def log_system_info(self):
 
         pytorch_version = torch.__version__
         self.logger.info(f"PyTorch Version: {pytorch_version}")
+        return system_info
 
     def check_ffmpeg_installed(self):
         """
@@ -210,7 +211,7 @@ def log_onnxruntime_packages(self):
         if onnxruntime_cpu_package is not None:
             self.logger.info(f"ONNX Runtime CPU package installed with version: {onnxruntime_cpu_package.version}")
 
-    def setup_torch_device(self):
+    def setup_torch_device(self, system_info):
         """
         This method sets up the PyTorch and/or ONNX Runtime inferencing device, using GPU hardware acceleration if available.
         """
@@ -222,7 +223,7 @@ def setup_torch_device(self):
         if torch.cuda.is_available():
             self.configure_cuda(ort_providers)
             hardware_acceleration_enabled = True
-        elif hasattr(torch.backends, "mps") and torch.backends.mps.is_available():
+        elif hasattr(torch.backends, "mps") and torch.backends.mps.is_available() and system_info.processor == "arm":
             self.configure_mps(ort_providers)
             hardware_acceleration_enabled = True
 
@@ -247,7 +248,7 @@ def configure_mps(self, ort_providers):
         """
         This method configures the Apple Silicon MPS/CoreML device for PyTorch and ONNX Runtime, if available.
         """
-        self.logger.info("Apple Silicon MPS/CoreML is available in Torch, setting Torch device to MPS")
+        self.logger.info("Apple Silicon MPS/CoreML is available in Torch and processor is ARM, setting Torch device to MPS")
         self.torch_device_mps = torch.device("mps")
 
         self.torch_device = self.torch_device_mps

pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "poetry.core.masonry.api"
 
 [tool.poetry]
 name = "audio-separator"
-version = "0.17.5"
+version = "0.17.6"
 description = "Easy to use audio stem separation, using various models from UVR trained primarily by @Anjok07"
 authors = ["Andrew Beveridge <[email protected]>"]
 license = "MIT"